Closed Bug 1973294 Opened 5 months ago Closed 5 months ago

'Delete' button in message header view may trigger deleting folders or message attachments.

Categories

(Thunderbird :: Message Reader UI, defect)

Thunderbird 138
defect

Tracking

(thunderbird_esr115 unaffected, thunderbird_esr128 unaffected, thunderbird_esr140 fixed, thunderbird140 wontfix, thunderbird141 fixed, thunderbird142 fixed)

RESOLVED FIXED
142 Branch
Tracking Status
thunderbird_esr115 --- unaffected
thunderbird_esr128 --- unaffected
thunderbird_esr140 --- fixed
thunderbird140 --- wontfix
thunderbird141 --- fixed
thunderbird142 --- fixed

People

(Reporter: jeffb, Assigned: welpy-cw)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: dataloss, regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36

Steps to reproduce:

  1. Open an attachment from within a message. (File opens in new window).
  2. Click the Delete key in the message header:
    Expected Action: TB should offer to delete the message containing the attachment(s)—NOT the attachment itself

Actual results:

TB offered to delete the attachment

Expected results:

TB should have offered to delete the message itself.
The correct behavior (see TB 115) is to only allow attachment behavior via right-click
menu on the particular attachment.

THIS IS A REGRESSION. THE CORRECT BEHAVIOR IS IN TB 115.

Status: UNCONFIRMED → NEW
Component: Untriaged → Message Reader UI
Ever confirmed: true
Regressed by: 1952481
Version: Thunderbird 128 → Thunderbird 138
Assignee: nobody → h.w.forms
Severity: -- → S3
Status: NEW → ASSIGNED

I'm using 128 on Mac Sequoia and it definitely is affected.

Target Milestone: --- → 142 Branch

Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/5a1cb763b2c6
Ensure header view delete button removes message, not attachment. r=darktrojan

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Comment on attachment 9496140 [details]
Bug 1973294 - Ensure header view delete button removes message, not attachment. r=#thunderbird-reviewers

Uplift Approval Request

  • Please state case for uplift consideration and ensure bug severity is set: Recent regression.
  • User impact if declined: The currently selected folder or the attachment of a message, not the message itself may be deleted.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Daily?: Yes
  • Has the fix been verified in Beta?: Yes
  • Needs manual test from QA?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple changes, covered by automated test.
  • String changes made/needed: None.
Attachment #9496140 - Flags: approval-comm-esr140?
Attachment #9496140 - Flags: approval-comm-beta?

Comment on attachment 9496140 [details]
Bug 1973294 - Ensure header view delete button removes message, not attachment. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9496140 - Flags: approval-comm-beta? → approval-comm-beta+
See Also: → 1977680
Duplicate of this bug: 1977680
Duplicate of this bug: 1978277

Changing description and upping severity since this involves potential data loss.

Severity: S3 → S2
Flags: needinfo?(corey)
Keywords: dataloss
Summary: After opening attachment, Delete in header key should NOT offer to delete attachment → 'Delete' button in message header view may trigger deleting folders or message attachments.

Comment on attachment 9496140 [details]
Bug 1973294 - Ensure header view delete button removes message, not attachment. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr140

Flags: needinfo?(corey)
Attachment #9496140 - Flags: approval-comm-esr140? → approval-comm-esr140+
See Also: → 1995417
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: