197429 - clear disk cache broken on MacOS X

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P1)

Description

[gordon]

Clearing the disk cache is broken on Mac OS X, because after clearing, the
nsIFile object mCacheDirectory returns NS_ERROR_FILE_ALREADY_EXISTS when
attempting to create a new directory, but it returns NS_ERROR_FILE_NOT_FOUND
when attempting to print out the path name.

Weird.

I'll look into the implementation of nsLocalFileMac to see how we get into this
state, but I'll probably work around it in the disk cache by storing the cache
directory parent (instead?) and clone that to perform operations on, because the
parent directory won't change when we clear the cache.

Comment 1

[gordon]

Attachment: proposed patch 1

The patch gets the parent directory before moving the cache directory, then
uses the parent directory to reset mCacheDirectory.  Seems to fix the problem
on Mac.

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 117282 [details] [diff] [review]
proposed patch 1

>Index: nsCache.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/netwerk/cache/src/nsCache.cpp,v
>retrieving revision 1.7
>diff -u -r1.7 nsCache.cpp
>--- nsCache.cpp	10 Mar 2003 23:19:02 -0000	1.7
>+++ nsCache.cpp	15 Mar 2003 01:01:49 -0000
>@@ -53,6 +53,8 @@
>     nsresult rv = item->GetNativePath(path);
>     if (NS_SUCCEEDED(rv)) {
>         PR_LOG(gCacheLog, level, (format, path.get()));
>+    } else {
>+        PR_LOG(gCacheLog, level, ("GetNativePath faile: %x", rv));

should be "failed", right?

>Index: nsDiskCacheDevice.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/netwerk/cache/src/nsDiskCacheDevice.cpp,v
>retrieving revision 1.83
>diff -u -r1.83 nsDiskCacheDevice.cpp
>--- nsDiskCacheDevice.cpp	10 Mar 2003 23:19:04 -0000	1.83
>+++ nsDiskCacheDevice.cpp	15 Mar 2003 01:01:49 -0000
>@@ -1058,8 +1066,11 @@
>     nsresult rv;
>     
>     rv = mCacheDirectory->Create(nsIFile::DIRECTORY_TYPE, 0777);
>-    if (NS_FAILED(rv)) return rv;
>-    
>+    CACHE_LOG_PATH(PR_LOG_ALWAYS, "\ncreate cache directory: %s\n", mCacheDirectory);
>+    CACHE_LOG_ALWAYS(("mCacheDirectory->Create() = %x\n", rv));
>+    if (NS_FAILED(rv)) {
>+        return rv;
>+    }

Please use a consistent style for this; every other place in the file has the
|if| and |return| on one line.

r=bryner with those changes.

Comment 3

[Simon Fraser [no longer active]]

Comment on attachment 117282 [details] [diff] [review]
proposed patch 1

sr=sfraser with bryner's comments addressed.

Comment 4

[gordon]

Patch (with suggested corrections) checked in.  Marking FIXED.