All users were logged out of Bugzilla on October 13th, 2018

[FIXr]Random CSS parser cleanup

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [whitebox])

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Just trying to get this out of my tree.  The substance is the removal of the
unused GetInfoMask() stuff and unused Init() function, change of the group stack
to nsCOMArray, change of some pointer members to nsCOMPtr, switch of booleans to
PRPackedBool, and addition some comments.
(Assignee)

Comment 1

16 years ago
Created attachment 117308 [details] [diff] [review]
O! To have no daily merge conflicts!
(Assignee)

Updated

16 years ago
Attachment #117308 - Flags: superreview?(dbaron)
Attachment #117308 - Flags: review?(dbaron)
Comment on attachment 117308 [details] [diff] [review]
O! To have no daily merge conflicts!

r+sr=dbaron if you change the line in CSSParserImpl::ParseURL from

      if (nsnull != mURL && css_RequiresAbsoluteURI(tk->mIdent)) {


to

      if (mURL && css_RequiresAbsoluteURI(tk->mIdent)) {
Attachment #117308 - Flags: review?(dbaron) → review+
Attachment #117308 - Flags: superreview?(dbaron) → superreview+
(Assignee)

Updated

16 years ago
Summary: [FIX]Random CSS parser cleanup → [FIXr]Random CSS parser cleanup
(Assignee)

Comment 3

16 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 4

16 years ago
verification can be done at code level
Whiteboard: [whitebox]
You need to log in before you can comment on or make changes to this bug.