Closed
Bug 197512
Opened 22 years ago
Closed 22 years ago
[FIXr]Random CSS parser cleanup
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Whiteboard: [whitebox])
Attachments
(1 file)
|
10.42 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
Just trying to get this out of my tree. The substance is the removal of the
unused GetInfoMask() stuff and unused Init() function, change of the group stack
to nsCOMArray, change of some pointer members to nsCOMPtr, switch of booleans to
PRPackedBool, and addition some comments.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #117308 -
Flags: superreview?(dbaron)
Attachment #117308 -
Flags: review?(dbaron)
Comment on attachment 117308 [details] [diff] [review]
O! To have no daily merge conflicts!
r+sr=dbaron if you change the line in CSSParserImpl::ParseURL from
if (nsnull != mURL && css_RequiresAbsoluteURI(tk->mIdent)) {
to
if (mURL && css_RequiresAbsoluteURI(tk->mIdent)) {
Attachment #117308 -
Flags: review?(dbaron) → review+
Attachment #117308 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Updated•22 years ago
|
Summary: [FIX]Random CSS parser cleanup → [FIXr]Random CSS parser cleanup
|
|
Assignee | |
Comment 3•22 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•