1975258 - QM: Add telemetry to count number of origins with zero usage

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

We want to collect telemetry on the number of origins that have zero usage. This telemetry will help us determine whether it's worthwhile to implement logic to clean up such unused origins. The goal is to reduce storage bloat and improve storage initialization times, especially for long-lived profiles with many origins.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1975258 - Adjust gtest names for Flatten to match dom-storage filter set; r=asuth,#dom-storage

Update gtest names for Flatten to reflect their current location. Since the
helper lives under dom/quota, the tests should be part of the dom-storage gtest
filter set.

This ensures regressions are caught by local runs rather than only on try
server or after landing.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1975258 - Fix Flatten to support std::distance; r=asuth,#dom-storage

Add standard iterator traits to FlatIter so it can be used with std::distance.
This brings Flatten in line with standard iterator requirements.

The gtests are updated to verify correct behavior by checking that ranges
report the expected distance.

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1975258 - Add generic helper for inserting origin infos; r=asuth,#dom-storage

Introduce a generalized MaybeInsertOriginInfos helper that accepts a predicate
for filtering origin infos. This allows future extensions where different
filtering criteria may be applied.

The existing MaybeInsertNonPersistedOriginInfos is updated to use the new
generic helper with a predicate that excludes persisted origins.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1975258 - Add telemetry for origins with zero usage; r=asuth,#dom-storage

Introduce telemetry to measure the number of origins with zero quota-charged
usage.

A new MaybeInsertNonPersistedZeroUsageOriginInfos helper is added to filter out
non-persisted origins that report zero usage. The RecordTemporaryStorageMetrics
method records this data after full temporary storage initialization.

This telemetry helps evaluate whether cleaning up unused origins is worthwhile.
The long-term goal is to reduce storage bloat and improve initialization
performance for profiles that have accumulated many empty origins over time.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e3035ee8892
https://hg.mozilla.org/integration/autoland/rev/68830ff63640
Adjust gtest names for Flatten to match dom-storage filter set; r=asuth,dom-storage-reviewers
https://github.com/mozilla-firefox/firefox/commit/6903dbdb6d11
https://hg.mozilla.org/integration/autoland/rev/f6543ab80f7c
Fix Flatten to support std::distance; r=asuth,dom-storage-reviewers
https://github.com/mozilla-firefox/firefox/commit/8707abc57ebf
https://hg.mozilla.org/integration/autoland/rev/536deba7ccc1
Add generic helper for inserting origin infos; r=asuth,dom-storage-reviewers
https://github.com/mozilla-firefox/firefox/commit/7650f7198089
https://hg.mozilla.org/integration/autoland/rev/79b1291f948c
Add telemetry for origins with zero usage; r=asuth,dom-storage-reviewers

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/68830ff63640
https://hg.mozilla.org/mozilla-central/rev/f6543ab80f7c
https://hg.mozilla.org/mozilla-central/rev/536deba7ccc1
https://hg.mozilla.org/mozilla-central/rev/79b1291f948c