197626 - PalmSyncInstall.exe (Address Book Palm Sync) has no customized icon (in Start Menu)

Status: VERIFIED FIXED

(MailNews Core Graveyard :: Palm Sync, enhancement)

Description

[Serge Gautherie (:sgautherie)]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312

(no details: rfe !)


Reproducible: Didn't try

Steps to Reproduce:
1. ((custom) Installed Mozilla)

Actual Results:  
In 'Start > Programs > Mozilla' menu, both 'A. B. P. S. Install' and  'A. B.
P. S. uninstall' have a default "windows program" icon (from Shell32.dll).


Expected Results:  
Add and use a customized icon.

Comment 1

[timeless]

confirmed 1.3 final
this can be fixed easily.

jglick: is there an icon available? the lack of an icon makes it look really
unprofessional, if you aren't adventurous you'd think the program wasn't
installed at all.

Comment 2

[Brian 'netdragon' Bober]

Fixing in bug 192703

Comment 3

[Serge Gautherie (:sgautherie)]

Reply to comment 2:

Agreed, with your bug 192703 comment 9: "palmsync needs to have icons in the
install program to use".

PS: I would say that the current bug (lake of icon) should block bug 192703
(install script fix), and reverse the current dependency way :->

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Bug still there.

Comment 5

[Serge Gautherie (:sgautherie)]

NB: With v1.4a, the menu path is now 'Start > Programs > Mozilla > Palm Tools'.

Comment 6

[Brian 'netdragon' Bober]

The bug is still there because there is no patch fully finished yet.

Comment 7

[Samir Gehani]

adt: nsbeta1+/adt2

Rafael to get the icons,  Once icons arrive please work with Marlon for
verification/icon approval and with Sean to check in the custom icon (by
reassigning the bug to Sean).  Thanks.

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4b) Gecko/20030507]

Bug still there. (with v1.3 profile, at least)

(Re comment 6: this is again a reminder status report, not a complain.)

Comment 9

[Rafael Ebron (:rebron)]

Attachment: Icon from 4.x

Comment 10

[Rafael Ebron (:rebron)]

The questions now are:
ideally is there time to modify what I have attached 
should we used what I have attached from 4.x, or rephrased is that better than
what's there now?

Comment 11

[Brian 'netdragon' Bober]

I can't see what you have attached.

Comment 12

[Rafael Ebron (:rebron)]

Attachment: Icon take two

Comment 13

[Brian 'netdragon' Bober]

I dunno why, but it doesn't display in Mozilla, or in MSDEV, but does on the
desktop.

Comment 14

[Sean Su]

Attachment: real icon

Turns out that the previous icon attachment was a .rc file.  This one just
contains the .ico.

Rafael, is this a mozilla, commercial/ns, or project neutral icon?  It looks
like it's an icon from 4.x.

Comment 15

[Brian 'netdragon' Bober]

Attachment: Giovanni template

Its up to ssu, but we should use Giovanni style, imho. Here is the template,
can you superimpose the tools on that?

Comment 16

[Brian 'netdragon' Bober]

Comment on attachment 124755 [details]
real icon

Changing MIME Type to image/x-icon so it displays properly in mozilla.

Comment 17

[Brian 'netdragon' Bober]

Attachment: install

These are ones I selected a while ago for the tools for the other patch I'm
working on. Its always flexible though, just requires a file replacement, a 5
second job.

Comment 18

[Brian 'netdragon' Bober]

Attachment: And uninstall

uninstall

Comment 19

[Brian 'netdragon' Bober]

what do you think? if you aren't able to, i can throw the giovanni template i
made, and the tools together. Or we could go with the standard setup icons.

Comment 20

[Sean Su]

Attachment: patch v1.0

this patch will add the .ico to the final .exe file.

Comment 21

[Sean Su]

Comment on attachment 125117 [details] [diff] [review]
patch v1.0

got rs=sgehani
seeking sr=

Comment 22

[Sean Su]

Attachment: patch v1.1

better patch.  it now compiles in two .ico files (installer and uninstaller
icons) and also updates the shortcut creation to use the right icon.

Comment 23

[Sean Su]

Comment on attachment 125121 [details] [diff] [review]
patch v1.1

got r=sgehani
seeking sr= now

Comment 24

[(not reading, please use [e-mail] instead)]

Comment on attachment 125121 [details] [diff] [review]
patch v1.1

sr/a=sspitzer

Comment 25

[Sean Su]

patch checked in to both trunk and branch using NeTDeMoN's install.ico and
uninstall.ico

Comment 26

[Ninoschka Baca]

Trunk and Branch build 2003-06-10: Win2k
Verified Fixed.

Comment 27

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4) Gecko/20030612]

(As reporter)
Confirming fixed.

Changing:
*bug 192703: 'depends on' -> 'blocks'.