197640 - What's related URLs being trimmed incorrectly

Status: RESOLVED WORKSFORME

(SeaMonkey :: Sidebar, defect)

Description

[Dave Gynn]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312

On the What's Related sidebar, the source URL for static files is always
shortened by one character.  This is caused by always trimming one character
from URLs with no query paramaters.

This error is in this bit of code
(http://lxr.mozilla.org/mozilla/source/xpfe/components/related/resources/related-panel.js#94)
var nQueryPart = sUrl.indexOf('?');
if (nQueryPart != 1) {
    sUrl = sUrl.slice(0, nQueryPart);
}

The logic should check for (nQueryPart != -1).


Reproducible: Always

Steps to Reproduce:
1.  Open the What's Related sidebar panel.
2.  Navigate directly to a URL with a file name and no query string (such as
http://www.mozilla.org/index.html)


Actual Results:  
What's related will show "http://www.mozilla.org/index.htm" (without the 'l'). 
Also, the shortened URL is sent to Alexa.  

Expected Results:  
It should show http://www.mozilla.org/index.html.

Comment 1

[Dave Gynn]

Attachment: updated js file

Comment 2

[Asa Dotzler [:asa]]

worksforme with 1.7 branch build on windows XP