197660 - Opening Folder Properties throws exception for non imap folders

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Sebastian Späth]

When doing bug 197209, I I noticed an uncaught exception:

1) In mailnews open the folder properties dialog through context menu
   (I tried, POP, local folder, and NNTP)


Result: 
JavaScript console throws an uncaught exception:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002
(NS_NOINTERFACE)"  location: "JS frame ::
chrome://messenger/content/folderProps.js :: hideShowControls :: line 229" 
data: no]

which is this line:
var imapFolder =
    gMsgFolder.QueryInterface(Components.interfaces.nsIMsgImapMailFolder);

Comment 1

[[e-mail]]

According to checkin comment it appears that none of bienvenu, sspitzer or
mscott knows how not to use QueryInterface ;-)

Comment 2

[[e-mail]]

Note: also move the call to moveToAlertPosition to the end of the load func.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

Comment 5

[[e-mail]]

Comment on attachment 117964 [details] [diff] [review]
patch

:-P