197694 - Add to Bookmarks or Bookmark this Page?

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Pham]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030314 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030314 Phoenix/0.5

*Bookmarks>Add to Bookmarks is different from context menu. Context menu says
"Bookmark this page..."

*You should change "Bookmarks>Add to Bookmarks" to "Bookmarks>Bookmark" This
Page, or change the context menu to "Add to Bookmarks"

*I prefer "Bookmark this Page" because websites usually say,"do you want to
Bookmark this page?"

*Also, if you think about "reading books"bookmarks, you can't add a book to a
skinny bookmark, but you can bookmark a book.

Reproducible: Always

Steps to Reproduce:
1. Go to menubar>bookmarks>add to bookmarks
2. Right-click on a page.
Actual Results:  
The bookmarking wording is different.

Expected Results:  
Say Bookmarks>Bookmark this page.

Comment 1

[Pierre Chanial]

confirming

Comment 2

[Sébastien Delahaye]

-> trivial

Comment 3

[Pham]

bookmark this page would also be consistent with Bookmark this Link

Comment 4

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 5

[Chad McHenry]

Attachment: Changes Bookmark menu from "Add to Bookmarks..." to "Bookmark This Page..."

Yes, it also changes the accelerator key to 'B'.  It made sense given consensus
to switch to this version.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 130405 [details] [diff] [review]
Changes Bookmark menu from "Add to Bookmarks..." to "Bookmark This Page..."

Simple enough patch, looks good to me.

Comment 7

[Mike Connor [:mconnor]]

*** Bug 217726 has been marked as a duplicate of this bug. ***

Comment 8

[Prognathous]

(In reply to mconnor, comment #6)
> (From update of attachment 130405 [details] [diff] [review])
> Simple enough patch, looks good to me.

So why not r= it and resolve this bug?

Prog.

Comment 9

[Prognathous]

Oops... please ignore my last comment - I didn't notice that p_ch was the
requested reviewer.

Sorry for the spam,

Prog.

Comment 10

[Mike Connor [:mconnor]]

Comment on attachment 130405 [details] [diff] [review]
Changes Bookmark menu from "Add to Bookmarks..." to "Bookmark This Page..."

yeah, this waited way too long

Comment 11

[Mike Connor [:mconnor]]

fixed, branch and trunk

Comment 12

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change