Closed Bug 197737 Opened 22 years ago Closed 21 years ago

[qt] misc cleanup for qt port

Categories

(Core Graveyard :: Ports: Qt, defect)

Other Branch
x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: opi, Assigned: opi)

Details

Attachments

(1 file, 1 obsolete file)

following clean ups:

- mIsToplevel and mListenForResizes are now in the same state like gtk after
creating widget

- setFocus sets the focus realy on the widget how xpfe it will

- implement isEnabled from nsIWidget, bring setEnabled down to QT Widget System

- remove GetBounds & GetClientBounds ... it's already in xpwidgets
- add WidgetToScreen transform in GetScreenBounds

The only thing that seems to working better as before is mentioned in bug 194749
(Tree widget doesn't work on Qt) ... the mouse click now selects the right
element that should be on this position but graphic is very broken.
Attached patch the big cleanup patch (obsolete) — Splinter Review
KaiRo: Kannst Du mal testen ob es gegen bug 194749 hilft ... also ob man mit der
Maus im Tree Widget navigieren kann.
Status: NEW → ASSIGNED
re comment #2:
It's better, though it still seems to fail sometimes. It's hard to tell
explicitely though because of those bad paint problems we have.
Attachment #117424 - Flags: review?(cbiesinger)
Comment on attachment 117424 [details] [diff] [review]
the big cleanup patch

 PRBool nsQBaseWidget::MoveEvent(QMoveEvent *aEvent)
...
+      return;

doesn't look right. I think you want to return PR_TRUE here...

-    qApp->processEvents(1);
hm, why is this no longer needed?

-NS_METHOD nsWindow::GetBounds(nsRect &aRect)
so Qt's nsWindow does not support borders?
(see nsBaseWidget.cpp: * If the implementation of nsWindow supports borders
this method MUST be overridden)

r=biesi with these things addressed
Attachment #117424 - Flags: review?(cbiesinger) → review-
1.) Yes, PR_TRUE is corrected.

2.) qApp->processEvents(1);
It seems that QT Elements are initialised erlyier in a different way, so they
needed a processEvent so that they don't look crappy if they are shown.
This is not needed it only makes the event handling a bit confuse.

3.) NS_METHOD nsWindow::GetBounds(nsRect &aRect)
Like GTK also QT doesn't coordinate own Bounds/Borders in nsWindow. (BeOS, Win
and OS/2 does it).
Attachment #117424 - Attachment is obsolete: true
Attachment #120895 - Flags: review?(cbiesinger)
Comment on attachment 120895 [details] [diff] [review]
the big cleanup patch 2

so sorry for the delay! I was quite busy in the last weeks, and completely
forgot about the bug. I promise to be faster next time.
Attachment #120895 - Flags: review?(cbiesinger) → review+
patch checked in on QT_REBIRTH_200302022_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
QA Contact: cbiesinger → ports-qt
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: