197823 - Scroll position of <a name> links not being remembered in browser history.

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jason Bassford]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030316
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030316

This is a spin-off from bug 197607.

Go to bug 197607 comment 10.  Observe that the browser has correctly scrolled so
that the 10th comment is visible.  Click back.  Click forward.  The scroll
position is now lost, and the document has been scrolled to the top.  Browser
history is ignoring the "#c10" HTML tag.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jason Bassford]

CCing Boris and David who worked on the patches for bug 197277 that might have
introduced this.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: This patch fixes it

Comment 3

[Boris Zbarsky [:bzbarsky]]

The question is, why does flushing there break framestate restoration?  jkeiser?
 Any ideas?

Comment 4

[Radha on family leave (not reading bugmail)]

bzbarsky or dbaron, who should own this bug?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 117488 [details] [diff] [review]
This patch fixes it

Whoever understands how scroll state restoration works and why an innocuous
flush breaks it.  That would be you or jkeiser.

We can check in the wallpaper for now, but there seems to be a bigger
underlying issue here....

In any case, reviews for the wallpaper would be good.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 117488 [details] [diff] [review]
This patch fixes it

There's nothing particularly wrong with this wallpaper -- it's restoring what
was happening before, and there's no need to flush before changing an event
state.

Comment 7

[John Keiser (jkeiser)]

Yes, I concur.  It is very odd, however--I'm not clear why *not* flushing would
make save or restore ever work better.  Less flushes is always better though.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 117488 [details] [diff] [review]
This patch fixes it

Checked in the patch.

jkeiser, do you want a separate bug on the issue of FlushPendingNotifications
breaking scroll state restoration here?  Or use this bug?  Or just ignore the
problem till after you finish rewriting state restoration stuff?

Comment 9

[Jason Bassford]

Confirming that the patch works in the 0318-04 Win32 build I just installed.

Comment 10

[John Keiser (jkeiser)]

Regarding FlushPendingNotificaitons, I'd probably ignore it for the moment
anyway.    It might come up intermittently anyway, so I'll keep it in the back
of my head.

Comment 11

[Boris Zbarsky [:bzbarsky]]

OK.  In that case....

Comment 12

[Jason Bassford]

.