1979917 - Ship upsert proposal

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P3)

Description

[Dan Minor [:dminor]]

Now that Upsert is at Stage 3, we can look at shipping it.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1979917 - Ship Upsert proposal; r=mgaudet!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1979917 - Tweak shipping instructions; r=mgaudet!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1979917 - Update test_xrayToJS.xhtml expectations; r=nika!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/602611a43b30
https://hg.mozilla.org/integration/autoland/rev/7c9a5b47e0d0
Ship Upsert proposal; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/b17e9bf41873
https://hg.mozilla.org/integration/autoland/rev/be72b7dda15e
Tweak shipping instructions; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/aa501fbb2399
https://hg.mozilla.org/integration/autoland/rev/dc94219d87a4
Update test_xrayToJS.xhtml expectations; r=nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bc745f09a830
https://hg.mozilla.org/integration/autoland/rev/ed67d7ac2721
Revert "Bug 1979917 - Update test_xrayToJS.xhtml expectations; r=nika" for failures on not-a-constructor.js

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for failures on not-a-constructor.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/ed67d7ac2721426aff5beb8bc6eaf17fa21b4d61
Log link: https://treeherder.mozilla.org/logviewer?job_id=526362532&repo=autoland&task=OSyEumt5RsqMwDRq-yoLIg.0&lineNumber=5042

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1979917 - Remove non262 upsert tests; r=mgaudet!

These tests are now all present in test262 and can be safely removed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7d3eb0b848b1
https://hg.mozilla.org/integration/autoland/rev/a2bc4078c981
Ship Upsert proposal; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/b86bb319f8c1
https://hg.mozilla.org/integration/autoland/rev/852d7663fa6e
Tweak shipping instructions; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/b55c1cc7001e
https://hg.mozilla.org/integration/autoland/rev/4f8004dd67bd
Update test_xrayToJS.xhtml expectations; r=nika
https://github.com/mozilla-firefox/firefox/commit/b15f5a0a2303
https://hg.mozilla.org/integration/autoland/rev/c927c988762b
Remove non262 upsert tests; r=mgaudet

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a2bc4078c981
https://hg.mozilla.org/mozilla-central/rev/852d7663fa6e
https://hg.mozilla.org/mozilla-central/rev/4f8004dd67bd
https://hg.mozilla.org/mozilla-central/rev/c927c988762b

Comment 10

[Donal Meehan [:dmeehan]]

:dminor, could you consider nominating this for a release note? (Process info)

Comment 11

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This adds new getOrInsert and getOrInsertComputed methods to Map and WeakMap.
[Affects Firefox for Android]: Yes.
[Suggested wording]: Support for the upsert proposal shipped in Firefox 144. This adds getOrInsert and getOrInsertComputed methods to Map and WeakMap. These methods either return the value associated with a key, or insert a default value, and then return that value, simplifying handling of cases where it's not known if a key is already present in the Map or WeakMap or not.
[Links (documentation, blog post, etc)]: https://github.com/tc39/proposal-upsert

Comment 12

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx144 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx144 release notes.

Comment 13

[Hamish Willee]

FF144 MDN work for this can be tracked in https://github.com/mdn/content/issues/41134

Comment 14

[Donal Meehan [:dmeehan]]

Added to the Fx144 release notes