197994 - Possible bug in spring-closing folder implementation

Status: NEW

(Core :: XUL, defect)

Description

[[e-mail]]

A patch to spring-close folders was checked in to fix bug 117954.

However, I don't think that it accounts for unclosed folders properly.

Case A.
1) Folder at index #3 springs open (2 children)
2) Folder at index #7 springs open (2 children)
3) Drop occurs on folder at index #5 (child of #3)
The code correctly springs closed the folder at index #7.

Case B.
1) Folder at index #7 springs open (2 children)
2) Folder at index #3 springs open (2 children)
3) Drop occus on folder at index #5 (child of #3)
The code tries to close the folder at index #7.
But because #3 is still open, this is now the folder that was at index #5.
Instead the folder at index #9 needs to be closed.

Comment 1

[Jan Varga [:janv]]

nominating, this should be easy to fix

Comment 2

[Samir Gehani]

Nav triage team: nsbeta1-

Please renominate nsbeta1 if the data/message is being dropped into the wrong
folder.  Thanks.

Comment 3

[Wayne Mery (:wsmwk)]

does problem still exist, and should this  block Bug 224193 and perhaps others?

xref: 
TB Bug 224193 - Mail folder expanded by drag-drop should re-collapse when done
SM Bug 236805 - [RFE] Dragging a mail over [-] symbol in front of folder should collapse folder
(fixed) Bug 117954 - Auto-close springloaded folders except the destination folder