1981086 - Enable layout.css.text-autospace.enabled in all channels

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Initially, the CSS text-autospace will be implemented behind the preference layout.css.text-autospace.enabled. After the layout rendering is ready, we can enable it in all channels in this bug.

Comment 1

[Sebastian Zartner [:sebo]]

Once enabled, this should be documented on MDN and added to the BCD. And it's also worth a release note, I think.

[Why is this notable]: Gives authors control over the spacing between adjacent characters.
[Affects Firefox for Android]: yes
[Suggested wording]: Implemented support for the text-autospace property, which provides authors control over the spacing between adjacent characters, allowing for automatic control over spacing between different scripts and around punctuation.
[Links (documentation, blog post, etc)]:
https://drafts.csswg.org/css-text-4/#text-autospace-property

Sebastian

Comment 2

[Marco Mucci [:MarcoM]]

No longer blocked - all dependencies resolved.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1981086 - Ship CSS text-autospace. r?#layout-jp-market-reviewers

That is, enable layout.css.text-autospace.enabled by default.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

We are planning to ship text-autospace in Firefox 146, where the 146 Nightly starts on Oct 13 https://whattrainisitnow.com/calendar/

Comment 5

[一丝]

I noticed that in bug 1987997, the default value was changed from normal to no-autospace. Was this done for performance reasons? Is there more performance test data available to share?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9a6db133a950
https://hg.mozilla.org/integration/autoland/rev/46be69544262
Ship CSS text-autospace. r=layout-jp-market-reviewers,jfkthame

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

(In reply to 一丝 from comment #5)

I noticed that in bug 1987997, the default value was changed from normal to no-autospace. Was this done for performance reasons? Is there more performance test data available to share?

Yes, we've seen performance regressions across several test suites in bug 1991421, bug 1991423, bug 1991424, bug 1991689. Even with the effort in bug 1989128, bug 1989851, bug 1991943 and bug 1991689, we still couldn't mitigate all of them. Also, using no-autospace as the default value is also compatible with blink and webkit.

[Edit: added two additional bugs that optimized the text-autospace performance.]

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/46be69544262

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No user impact if we are not shipping text-autospace in Firefox 145, but we'd like the feature to gain more exposure. See also the uplift request in bug 1987997.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: If combining the uplifted patch in Bug 1987997, auto-spacing is not applied by default on web pages, making the risk lower.
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1981086 - Ship CSS text-autospace. r?#layout-jp-market-reviewers

That is, enable layout.css.text-autospace.enabled by default.

Original Revision: https://phabricator.services.mozilla.com/D264365

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e8ea2ef8fe50
https://hg.mozilla.org/releases/mozilla-beta/rev/ce6c78d78fb9

Comment 12

[Brian Thomas Smith [bsmth]]

MDN docs changes can be tracked in the following GitHub issue https://github.com/mdn/content/issues/41501

Comment 13

[Pascal Chevrel:pascalc]

Added to our final 145 release notes.