198219 - CVS filenames with spaces cause VC_CVS to fail with '==' message

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox2, defect)

Description

[Dan Prince]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020826

If a file with spaces in the filename is checked into CVS, the tinder.cgi script
fails with this message:

[Fri Mar 14 11:15:00 2003] tinder.cgi: Can not parse CVS history output, '=='
not in right place,: 'A 2003-03-06 16:50 +0000 username   1.1             
filename withspaces.txt                                       path/to/dir/logos
                                  == <remote>



Reproducible: Always

Steps to Reproduce:
1. In a tree monitored by tinderbox2, check in a file with spaces in the filename.
2. check output of tinder.cgi for error message mentioned above
3.

Actual Results:  
tinder.cgi fails with error message; tinderbox2 status web page not updated

Expected Results:  
Correctly parse filename from cvs history command.

Comment 1

[Dan Prince]

Attachment: patch to fix parsing of CVS filenames

Someone who knows perl better than I should fix this up, but this seems to work
for me.

Comment 2

[Mike Taylor [:bear]]

fixed in rev 1.32

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=VC_CVS.pm&branch=&root=/cvsroot&subdir=mozilla/webtools/tinderbox2/src/lib/TinderDB&command=DIFF_FRAMESET&rev1=1.31&rev2=1.32