1982555 - Rename the __HostHttp- cookie prefix to __Host-Http-

Status: RESOLVED FIXED

(Core :: Networking: Cookies, enhancement, P2)

Description

[Yoav Weiss]

Steps to reproduce:

In https://github.com/whatwg/cookiestore/pull/286 and https://github.com/httpwg/http-extensions/pull/3153 we're renaming the __HostHttp- cookie prefix to make it easier for servers to deploy before the prefix is supported, without losing the __Host- semantics.

Expected results:

We should rename the cookie prefix to align with that

Comment 1

[Valentin Gosu [:valentin] {{ PTO 3 July - 3 August }}]

This should be as simple as updating CookiePrefixes::eHostHttp to be "__Host-Http-"

Comment 2

[edgul]

Attachment: Bug 1982555 - Rename the __HostHttp- cookie prefix to __Host-Http- r?valentin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8c5c1541234f
https://hg.mozilla.org/integration/autoland/rev/5de56bd94f33
Rename the __HostHttp- cookie prefix to __Host-Http- r=valentin,cookie-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/783b68885d9a
https://hg.mozilla.org/integration/autoland/rev/3b7bf8912792
Revert "Bug 1982555 - Rename the __HostHttp- cookie prefix to __Host-Http- r=valentin,cookie-reviewers" for causing wpt failures cookiestore related

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b4ecbaf716f
https://hg.mozilla.org/integration/autoland/rev/c313898dee90
Rename the __HostHttp- cookie prefix to __Host-Http- r=valentin,cookie-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c313898dee90

Comment 8

[Tom Schuster]

Would it make sense to uplift to 143? That might make it less likely that someone would use the old name.

Comment 9

[Yoav Weiss]

FWIW, That's what I'm doing in chromium

Comment 10

[Tom Schuster]

[Tracking Requested - why for this release]: The name of this HTTP header changed shortly after it reached release Firefox. We should minimize the time with the "wrong" name.

Comment 11

[Ryan VanderMeulen (PTO, back July 27)]

A Beta uplift request would be more helpful than a tracking request :-). Also, we could potentially get this into a 142 dot release if people think it's important enough.

Comment 12

[edgul]

Comment on attachment 9506750 [details]
Bug 1982555 - Rename the __HostHttp- cookie prefix to __Host-Http- r?valentin

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Discrepancy between firefox versions for cookie prefixes. Cookie behaviour will not be consistent across versions and not work as expected in both.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Original feature has not been in release that long.
• String changes made/needed:
• Is Android affected?: Yes

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9506750 [details]
Bug 1982555 - Rename the __HostHttp- cookie prefix to __Host-Http- r?valentin

Approved for 143.0b5
Approved for 142.0.1

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c1e1eeda8892
https://hg.mozilla.org/releases/mozilla-beta/rev/edcc62f09d34

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9f5bd36de047
https://hg.mozilla.org/releases/mozilla-release/rev/bd16b9e4166c

Comment 16

[Hamish Willee]

FYI Compatibility data updated in https://github.com/mdn/browser-compat-data/pull/27930