/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:86:35: InstallCleanupDefines.h: Datei oder Verzeichnis nicht gefunden /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:87:31: nsISoftwareUpdate.h: Datei oder Verzeichnis nicht gefunden /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp: In function `nsresult VerifyInstallation(int, char**)': /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:976: `CLEANUP_REGISTRY' undeclared (first use this function) /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:976: (Each undeclared identifier is reported only once for each function it appears in.) /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:985: `CLEANUP_MESSAGE_FILENAME' undeclared (first use this function) /home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:989: `CLEANUP_UTIL' undeclared (first use this function) attahcing a patch in a second
15 years ago
Comment on attachment 117772 [details] [diff] [review] patch sr=alecf but this is still really lame. xpfe/bootstrap should not have a dependency on xpinstall! Who reviewed that?!
Comment on attachment 117772 [details] [diff] [review] patch if jag sr's this patch, I am okay with it.
how odd. It seems that that dependency has been there for quite a long time. Its still lame and incorrect. I welcome a solution that doesn't involve #ifdefs
Comment on attachment 117772 [details] [diff] [review] patch sr=jag. File a new bug on removing the xpinstall dependency from nsAppRunner.cpp?
Checking in nsAppRunner.cpp; /cvsroot/mozilla/xpfe/bootstrap/nsAppRunner.cpp,v <-- nsAppRunner.cpp new revision: 1.393; previous revision: 1.392 done filed Bug 198584
Was anyone going to ask someone in XPInstall about this (or even the perf people who prompted this change)? We could certainly make XPInstall an appstartup component again and uselessly load it each startup "just in case" it had an incomplete upgrade to finish up.