--disable-xpinstall breaks mozilla build

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:86:35: InstallCleanupDefines.h:
Datei oder Verzeichnis nicht gefunden
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:87:31: nsISoftwareUpdate.h:
Datei oder Verzeichnis nicht gefunden
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp: In function `nsresult
VerifyInstallation(int, char**)':
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:976: `CLEANUP_REGISTRY'
undeclared (first use this function)
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:976: (Each undeclared
identifier is reported only once for each function it
appears in.)
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:985: `CLEANUP_MESSAGE_FILENAME'
undeclared (first use this function)
/home/chb/mozilla/xpfe/bootstrap/nsAppRunner.cpp:989: `CLEANUP_UTIL' undeclared
(first use this function)

attahcing a patch in a second
Created attachment 117772 [details] [diff] [review]
patch
Attachment #117772 - Flags: review?(dougt)

Comment 2

15 years ago
Comment on attachment 117772 [details] [diff] [review]
patch

sr=alecf but this is still really lame. xpfe/bootstrap should not have a
dependency on xpinstall! Who reviewed that?!
Attachment #117772 - Flags: superreview+

Comment 3

15 years ago
Comment on attachment 117772 [details] [diff] [review]
patch

if jag sr's this patch, I am okay with it.
Attachment #117772 - Flags: review?(dougt) → review+

Comment 4

15 years ago
how odd. It seems that that dependency has been there for quite a long time. Its
still lame and incorrect. I welcome a solution that doesn't involve #ifdefs

Comment 5

15 years ago
Comment on attachment 117772 [details] [diff] [review]
patch

sr=jag. File a new bug on removing the xpinstall dependency from
nsAppRunner.cpp?
Checking in nsAppRunner.cpp;
/cvsroot/mozilla/xpfe/bootstrap/nsAppRunner.cpp,v  <--  nsAppRunner.cpp
new revision: 1.393; previous revision: 1.392
done

filed Bug 198584
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Was anyone going to ask someone in XPInstall about this (or even the perf people
who prompted this change)?

We could certainly make XPInstall an appstartup component again and uselessly
load it each startup "just in case" it had an incomplete upgrade to finish up.
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.