Closed
Bug 198428
Opened 21 years ago
Closed 21 years ago
Image Preview blank; images don't render after drag/drop
Categories
(SeaMonkey :: Composer, defect, P1)
SeaMonkey
Composer
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.4alpha
People
(Reporter: tracy, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.01 KB,
patch
|
Brade
:
review+
blizzard
:
superreview+
|
Details | Diff | Splinter Review |
5.61 KB,
patch
|
timeless
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Reporter | ||
Comment 1•21 years ago
|
||
seen on commercial trunk builds: windows 2003-03-19-05-trunk & 2003-03-20-04-trunk linux 2003-03-19-05-trunk & 2003-03-20-05-trunk mac 2003-03-19-03-trunk & 2003-03-20-03-trunk -open a new composer window -Click Image -select an image to insert in the file picker dialog -click open the image does not in the Preview Image window as expected. The actual size dimensions are displayed next to the preview image window, just no image in Preview. note: builds from the 18th work as expected
Keywords: regression
Comment 2•21 years ago
|
||
Confirming this problem in the 2003-03-20-03 Mach-o trunk build. I also noticed if I drag and drop a image into the composer window, I get a broken image icon instead of the actual image.
Comment 3•21 years ago
|
||
Confirming the drag/drop image issue problem happened at the same time as the image preview regression. The Mach-0 2003-03-19-03 and Win32 2003-03-19-05 trunk builds both show this problem. Basically, if you drag/drop a image (gif, jpg, or png) into a composer window, the image isn't displayed. Instead, you get a broken image icon. If I save the file and click Composer's browse icon, the image is properly displayed in the browser window .
Updated•21 years ago
|
Severity: normal → critical
Comment 4•21 years ago
|
||
-->bzbarsky
Assignee: composer → bzbarsky
Flags: blocking1.4a?
Summary: Image Preview blank → Image Preview blank; images don't render after drag/drop
Assignee | ||
Comment 5•21 years ago
|
||
OK. Someone give me a hand here, because I have basically no time to work on this for alpha.... 1) How exactly is the preview created (pointer to the code)? Is bug 198346 relevant? 2) What exactly happens when the image is dragged and dropped into composer (pointer to the code)? Thanks in advance....
Priority: -- → P1
Target Milestone: --- → mozilla1.4alpha
Assignee | ||
Comment 6•21 years ago
|
||
Image preview is being bitten by bug 198435. This fixes the problem by simply setting the src before appending the image to the document.
Assignee | ||
Updated•21 years ago
|
Attachment #117912 -
Flags: superreview?(kin)
Attachment #117912 -
Flags: review?(brade)
Assignee | ||
Comment 7•21 years ago
|
||
Assignee | ||
Comment 8•21 years ago
|
||
Comment on attachment 117919 [details] [diff] [review] Fix for D&D, as well as copy/paste of images Per Kathy's request, I will change the + NS_WARN_IF_FALSE(aDocument, "Must have a document"); to nothing before checking in.
Attachment #117919 -
Flags: superreview?(jst)
Attachment #117919 -
Flags: review?(brade)
Comment 9•21 years ago
|
||
Comment on attachment 117912 [details] [diff] [review] Fix for image preview please add a comment to clarify that adding the image with no src sidesteps the alt issue (as we discussed on irc) r=brade
Attachment #117912 -
Flags: review?(brade) → review+
Comment 10•21 years ago
|
||
Comment on attachment 117912 [details] [diff] [review] Fix for image preview sr=blizzard
Attachment #117912 -
Flags: superreview?(kin) → superreview+
Comment 11•21 years ago
|
||
Comment on attachment 117919 [details] [diff] [review] Fix for D&D, as well as copy/paste of images > // pasting, as well as _for_ drag&drop. So if we are to have composer sorta
Attachment #117919 -
Flags: review?(brade) → review+
Comment 12•21 years ago
|
||
another side-effect of this (commercial side) is that graphical smileys in NIM don't appear. strangely, graphical smileys appear to work in html mail compose (afaict).
Assignee | ||
Comment 13•21 years ago
|
||
Well, I get to land these patches and then see how NIM is... ;)
Comment 14•21 years ago
|
||
Comment on attachment 117919 [details] [diff] [review] Fix for D&D, as well as copy/paste of images sr=jst
Attachment #117919 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 15•21 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 16•21 years ago
|
||
verified with commercial trunk builds: windows 2003-03-21-04-trunk linux 2003-03-21-05-trunk mac 2003-03-21-03-trunk
Status: RESOLVED → VERIFIED
Updated•21 years ago
|
Flags: blocking1.4a?
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•