Closed
Bug 198601
Opened 22 years ago
Closed 22 years ago
Move QI outside of RegisterGenericFactory
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbradley, Assigned: dougt)
Details
(Keywords: perf)
Attachments
(1 file)
|
2.17 KB,
patch
|
dougt
:
review+
dougt
:
superreview+
|
Details | Diff | Splinter Review |
Remove the QI that occurs in RegisterGenericFactory to its caller. This will
eliminate a lot of unecessary AddRef/Release and QI calls.
|
Reporter | |
Comment 1•22 years ago
|
||
Attachment #118020 -
Flags: review?(dougt)
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 118020 [details] [diff] [review]
Moves the QI outside
nice. check it in.
Attachment #118020 -
Flags: superreview+
Attachment #118020 -
Flags: review?(dougt)
Attachment #118020 -
Flags: review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 118020 [details] [diff] [review]
Moves the QI outside
why do you need the static cast?
|
|
Reporter | |
Comment 4•22 years ago
|
||
The compiler made me do it ;-)
I it's a multiple inheritance issue. The compiler was complaining about
ambiguities. It didn't know which nsISupports branch of the inheritance tree to use.
|
|
Reporter | |
Comment 5•22 years ago
|
||
Patch checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Summary: Remove QI outside of RegisterGenericFactory → Move QI outside of RegisterGenericFactory
You need to log in
before you can comment on or make changes to this bug.
Description
•