1986060 - Autocomplete contents jiggle up-and-down when I type/delete space character (from recommended resource name disappearing/reappearing)

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Start Firefox with a fresh profile.
2. Type "cors" into the URLbar.
   --> Hopefully there's a "Recommended resource" autocompletion for MDN, with a large paragraph. If not, open a new tab and repeat step 2 (I think we populate this suggestion somewhat lazily).
3. Type a space character after "cors"
4. Press backspace to delete that space character.
5. Repeat steps 3-4 (type/delete space character), and watch the autocomplete popup.

EXPECTED RESULTS:
Results shouldn't change (and more importantly, their layout shouldn't change)
Specifically: the recommended-resource's label/button mentioned in ACTUAL RESULTS should remain consistently visible, since the recommended resource itself is remaining consistently visible.

ACTUAL RESULTS:

• The "Recommended resource" section very briefly changes its height. (Watching in slow motion, it looks like it's because the "MDN Web Docs" label [just below the paragraph] gets briefly removed and then added-back.)
• The orange URL (for the recommended-resource) briefly stops being truncated/ellipsized, and then gets truncated/ellipsized again. (Watching in slow motion, this seems to be because the "Feedback" button disappears and then reappears.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 2

[Daniel Holbert [:dholbert]]

I'm using Firefox Nightly 144.0a1 (2025-08-29) (64-bit) on Ubuntu 24.04 (though I imagine this isn't platform-dependent)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:daisuke, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Drew Willcoxon :adw]

Thanks Daniel, I think this is bug 1995538 but don't want to dupe it without investigating.

Comment 5

[Daniel Holbert [:dholbert]]

Yup -- looks like essentially the same issue.

(Both bugs are about an awesomebar result that has a "Feedback" button to the right and a label at the bottom; and in both bugs, the feedback-button and bottom-label briefly disappear/reappear when the user types a character. In the other bug, it's a Yelp sponsored link (e.g. at t=10s in that bug's screencast, with the disappearing-label being the "Yelp - Sponsored" text)

Comment 6

[Drew Willcoxon :adw]

The "MDN Web Docs" string at the bottom also pops in, but it's less noticeable compared to the feedback button. Fixing bug 1995538 won't fix that, so we'll need to do that here.

Comment 7

[Daniel Holbert [:dholbert]]

(In reply to Drew Willcoxon :adw from comment #6)

The "MDN Web Docs" string at the bottom also pops in

That happens in the other bug's screencast, too, FWIW - the string disappearing & popping back in there is "Yelp - Sponsored" (at t=10s in the screencast).

Anyway, I'm happy to have this bug or another followup track that issue if it's not addressed by what landed so far.

Comment 8

[Drew Willcoxon :adw]

It does, and the "Recommended" text of the addon suggestion pops in too. Probably simplest to handle them all here in this bug since the fixes are trivial and will all be the same. We should check for other pop-in too but here's a summary of everything so far:

• MDN Web Docs
• Recommended (in addon suggestions)
• Yelp - Sponsored

Thanks Daniel, I always appreciate your filing urlbar bugs. :-)

Comment 9

[Drew Willcoxon :adw]

Attachment: Bug 1986060 - Cache the l10n bottom-text strings for some Suggest urlbar results.

I'd like to make cacheable true by default, but there are some larger concerns
around that, and for now I just want to narrowly fix this flicker.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aacb4231f4e8
https://hg.mozilla.org/integration/autoland/rev/55357405c435
Cache the l10n bottom-text strings for some Suggest urlbar results. r=daisuke,urlbar-reviewers

Comment 11

[Drew Willcoxon :adw]

Attachment: Bug 1986060 - Cache the l10n bottom-text strings for some Suggest urlbar results.

I'd like to make cacheable true by default, but there are some larger concerns
around that, and for now I just want to narrowly fix this flicker.

Original Revision: https://phabricator.services.mozilla.com/D272367

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This is a nice-to-have that fixes some flicker. The flicker has been present for many releases now -- not a recent problem.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Should be clear from the bug: MDN, addon/AMO, and Yelp suggestions should not flicker when triggered repeatedly.
• Risk associated with taking this patch: low
• Explanation of risk level: Three-line patch that simply caches a few l10n strings so they don't pop in in the UI.
• String changes made/needed: none
• Is Android affected?: no

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/55357405c435

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/22857baab889
https://hg.mozilla.org/releases/mozilla-beta/rev/c6a8ac673c6e

Comment 15

[Peter Magyari (Desktop QA)]

Verified fixed using Nightly 147.0a1 (20251113163320) on Windows 10, MacOS 15.5 and Ubuntu 24.04.