1986564 - Moving or copying a folder to EWS doesn't include subfolders

Status: RESOLVED FIXED

(MailNews Core :: Networking: Exchange, task, P1)

Description

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

In bug 1975710 I'm adding a test that moves and copies folders across servers. In all cases except if the destination folder is EWS, subfolders are handled. This bug is about fixing EWS to match.

There's some TODOs in the test file that need fixing when this bug is fixed.

Comment 1

[Justin Tracey [:jtracey]]

Took a little effort to reproduce this: the bug only occurs if the folder being copied has subfolders and messages. Looks like the OnStartCopy, OnStopCopy, etc. callbacks aren't being invoked if the listener is given to CopyMessages. I'll see if I can find why.

Comment 2

[Justin Tracey [:jtracey]]

Attachment: Bug 1986564 - Copy folder messages via CopyService. r=#thunderbird-back-end-reviewers

The listener isn't registered if CopyMessages is directly invoked on the
folder object.

Comment 3

[Justin Tracey [:jtracey]]

Comment on attachment 9523338 [details]
Bug 1986564 - Copy folder messages via CopyService. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: This fixes copying/moving folders with messages and subfolders to an EWS mailbox.
• User impact if declined: Without this patch, any attempt to move a folder with messages and subfolders will copy the top-level folder and messages, but silently fail to copy the subfolders and any of its messages and sub-subfolders.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: No
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is effectively two lines, switching from a call to the internal EWS "folder" interface to the internal "copy" interface. The code is well covered by tests, and will only affect EWS accounts.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 4

[Corey Bryant]

Comment on attachment 9523338 [details]
Bug 1986564 - Copy folder messages via CopyService. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21f950655cca
Copy folder messages via CopyService. r=mkmelin

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 145.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/1b72f56ce40e