1986631 - [css-attr] Implement support for type(<syntax>)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

type(<syntax>) should be reusable from the typed custom properties support and should be straight-forward. raw-string` should be easy too as that’s the default.

<attr-unit> seems a bit tricky / annoying for our setup (we don’t have a central registry of supported units, though we may want to maybe reuse some of the calc() code).

Might want to implement maybe px, %, and a couple easy ones to get most tests working, and work on the full support / rejiggering our unit set-up in a separate bug.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Actually this seems like close enough, so I'd probably start looking there.

Comment 2

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 1986631 - Implement support for Type(<syntax>) and handle default as raw-string. r=dshin,emilio

Comment 3

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 1986631 - Add WPT to test not parsing type(*) in var. r=emilio

Comment 4

[Diego Ciudad Real Escalante [:descalante]]

Attachment: Bug 1986631 - Add expected WPT passes with css-attr enabled. r=emilio,dshin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b72f0a4301a
https://hg.mozilla.org/integration/autoland/rev/a1ca473cc6f6
Implement support for Type(<syntax>) and handle default as raw-string. r=firefox-style-system-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/b40a8ab6e501
https://hg.mozilla.org/integration/autoland/rev/644e69f1bc6d
Add WPT to test not parsing type(*) in var. r=emilio
https://github.com/mozilla-firefox/firefox/commit/ac87939bf7bc
https://hg.mozilla.org/integration/autoland/rev/4ce2b7080d18
Add expected WPT passes with css-attr enabled. r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56811 for changes under testing/web-platform/tests

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a1ca473cc6f6
https://hg.mozilla.org/mozilla-central/rev/644e69f1bc6d
https://hg.mozilla.org/mozilla-central/rev/4ce2b7080d18

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Dave Letorey]

Related Bug

• When the attr(data-value type(x)) is used it set the value for all instances from the first instance

Comment 10

[Dave Letorey]

Related issues and pull requests

• BCD PR
• Firefox release PR