1986681 - Ship CSS Module Scripts

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task)

Description

[Dan Minor [:dminor]]

Once CSS Module Scripts have been on Nightly for a few releases, we can look into shipping it.

Comment 1

[Dan Minor [:dminor]]

I don't think supporting this in chrome is a blocker to shipping the feature.

Comment 2

[jochen.kuehner]

I only can say that I've tested FF nightly with css imports extensively. We have a designer wich heavily depends on css modules: https://node-projects.github.io/web-component-designer-demo/index.html
Yeah my demo uses the polyfill, but in our company we have huge applications wich depend on them and everything works now.

So I would say, better ship earlier then later.

Comment 3

[Dan Minor [:dminor]]

Tentatively planning this for Firefox 147.

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1986681 - Ship css module scripts; r=emilio!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b26c65fcbc14
https://hg.mozilla.org/integration/autoland/rev/8e5b850905ab
Ship css module scripts; r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/42ff5ed800be
https://hg.mozilla.org/integration/autoland/rev/7d9ef60c5974
Revert "Bug 1986681 - Ship css module scripts; r=emilio" for causing css related wpt failures. DONTBUILD

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing css related wpt failures

Push with failures

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=536388222&repo=autoland&task=Q85rTtlhTQyG2_0SFA6qjA.0
• https://treeherder.mozilla.org/logviewer?job_id=536388843&repo=autoland&task=LYdQwrqVQ8u0Rg4oJOKiGA.0

Backout link

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1986681 - Update wpt expectations; r=emilio!

This is a new test that previously errored with css module scripts disabled, now it has failures, but
the failures are consistent with the other tests for shadow root adopted stylesheets, and don't
seem to be related to css module scripts.

Depends on D272993

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4c8e0c4d9751
https://hg.mozilla.org/integration/autoland/rev/a4f8b1d2c983
Ship css module scripts; r=emilio
https://github.com/mozilla-firefox/firefox/commit/8f418aade369
https://hg.mozilla.org/integration/autoland/rev/375183f58404
Update wpt expectations for shadowrootadoptedstylesheets-fetched-module.html; r=emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3cd3ce238ba0
https://hg.mozilla.org/integration/autoland/rev/05aed38ed69e
Revert "Bug 1986681 - Update wpt expectations for shadowrootadoptedstylesheets-fetched-module.html; r=emilio" for causing failures at import-style-allowed.sub.html.

Comment 11

[Atila Butkovits]

Backed out for causing failures at import-style-allowed.sub.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/05aed38ed69e258a16babb3cd4e6902033abf0bd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=375183f584041eb634e2e08d5f42454b11389823&selectedTaskRun=Umi-UxA5TgaXxaFEur6oQg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=536594072&repo=autoland&task=Umi-UxA5TgaXxaFEur6oQg.0&lineNumber=1720

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4d587362a4cb
https://hg.mozilla.org/integration/autoland/rev/4d0aeef82649
Ship css module scripts; r=emilio
https://github.com/mozilla-firefox/firefox/commit/c88006d7cb01
https://hg.mozilla.org/integration/autoland/rev/86b9a226996d
Update wpt expectations; r=emilio

Comment 13

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4d0aeef82649
https://hg.mozilla.org/mozilla-central/rev/86b9a226996d

Comment 14

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4d0aeef82649
https://hg.mozilla.org/mozilla-central/rev/86b9a226996d

Comment 15

[Donal Meehan [:dmeehan]]

:dminor, could you add a release note request here?

Comment 16

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This adds support for CSS Module Scripts, a feature that has been present in Chromium for quite a while, and is frequently requested by developers.
[Affects Firefox for Android]: Yes
[Suggested wording]: CSS Module Scripts allow stylesheets to be imported using the JavaScript module system and import attributes, for more information, please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#loading_non-javascript_resources.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules#loading_non-javascript_resources.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx147 relnotes.

Comment 18

[Hamish Willee]

FF147 work for this can be tracked in https://github.com/mdn/content/issues/42255.

Does this also allow the syntax assert {type: 'css'} - I ask not because I expect it does, but because the implementation bug is linked from the compatibility data. So either that link should be removed or the feature should be marked as supported.

Comment 19

[Dan Minor [:dminor]]

The assert syntax was removed (we unshipped it in https://bugzilla.mozilla.org/show_bug.cgi?id=1910686, according to that bug, Chromium unshipped it at the same time as well) so we should be able to remove references to it from the documentation. I'd fix the link, but I'm not sure which link you mean :)

Comment 20

[Hamish Willee]

Cheers. I'll sort it.