198677 - Attribute parser doesn't allow negative values

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[John Keiser (jkeiser)]

Attribute parsing in nsHTMLValue::ParseIntValue isn't working right with
negative values.  This is causing stuff like
http://bugzilla.mozilla.org/attachment.cgi?id=103432&action=view to have
problems (those lists should start at -2 and -20).

Comment 1

[John Keiser (jkeiser)]

Attachment: Patch

Comment 2

[John Keiser (jkeiser)]

A new fix is forthcoming tomorrow, that restores the old behavior better (my net
access is going to be down until then).

Comment 3

[John Keiser (jkeiser)]

Attachment: Patch v2

This patch keeps ParseIntValue for the few callers who don't need the special
rounding and % / * behavior, and adds ParseSpecialIntValue for those callers,
removing the default value for the last parameter in the process.

Comment 4

[John Keiser (jkeiser)]

Attachment: Patch v2 -u9

Same diff with more context

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 118485 [details] [diff] [review]
Patch v2 -u9

r=smontagu

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 118485 [details] [diff] [review]
Patch v2 -u9

sr=jst

Comment 7

[John Keiser (jkeiser)]

Comment on attachment 118485 [details] [diff] [review]
Patch v2 -u9

This only affects <ol>, but is a very silly regression.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 118485 [details] [diff] [review]
Patch v2 -u9

a=asa (on behalf of drivers) for checkin to 1.4a

Comment 9

[John Keiser (jkeiser)]

Fix checked in.