198712 - UMR in nsMsgNewsFolder::NotifyDownloadedLine

Status: VERIFIED DUPLICATE of bug 212596

(MailNews Core :: Networking: NNTP, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Trunk, self-built Windows 2000 debug build.

Reading a newsgroup, I get:

[W] UMR: Uninitialized memory read in nsMsgNewsFolder::NotifyDownloadedLine(char
const*,UINT) {1 occurrence}
    Reading 4 bytes from 0x0b225660 (4 bytes at 0x0b225660 uninitialized)
    Address 0x0b225660 is 184 bytes into a 328 byte block at 0x0b2255a8
    Address 0x0b225660 points to a C++ new block in heap 0x026d0000
    Thread ID: 0xdc4
    Error location
    nsMsgNewsFolder::NotifyDownloadedLine(char const*,UINT) [nsNewsFolder.cpp:1738]
        rv = StartNewOfflineMessage();
      }
    
 =>   m_numOfflineMsgLines++;
    
      if (m_tempMessageStream)
      {
    nsNNTPProtocol::DisplayArticle(nsIInputStream *,UINT) [nsNNTPProtocol.cpp:2539]
            }
    
        if (m_newsFolder)
 =>       m_newsFolder->NotifyDownloadedLine(line, m_key);
    
            if (line[0] == '.' && line[1] == 0)
            {
    nsNNTPProtocol::ReadArticle(nsIInputStream *,UINT) [nsNNTPProtocol.cpp:2606]
    nsNNTPProtocol::ProcessProtocolState(nsIURI *,nsIInputStream *,UINT,UINT)
[nsNNTPProtocol.cpp:5158]
    nsMsgProtocol::OnDataAvailable(nsIRequest *,nsISupports *,nsIInputStream
*,UINT,UINT) [nsMsgProtocol.cpp:327]
    nsInputStreamPump::OnStateTransfer(void) [nsInputStreamPump.cpp:406]
    nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream *)
[nsInputStreamPump.cpp:321]
    nsInputStreamReadyEvent::EventHandler(PLEvent *) [nsStreamUtils.cpp:111]
    PL_HandleEvent [plevent.c:663]
    PL_ProcessPendingEvents [plevent.c:593]
    Allocation location
    new(UINT)      [new.cpp:23]
    nsMsgNewsFolderConstructor [nsMsgNewsFactory.cpp:70]
        NS_GENERIC_FACTORY_CONSTRUCTOR(nsNNTPArticleList)
        NS_GENERIC_FACTORY_CONSTRUCTOR(nsNNTPNewsgroupPost)
        NS_GENERIC_FACTORY_CONSTRUCTOR(nsNNTPNewsgroupList)
     => NS_GENERIC_FACTORY_CONSTRUCTOR(nsMsgNewsFolder)
        NS_GENERIC_FACTORY_CONSTRUCTOR(nsNewsDownloadDialogArgs)
        
        static const nsModuleComponentInfo components[] =
    nsGenericFactory::CreateInstance(nsISupports *,nsID const&,void * *)
[nsGenericFactory.cpp:86]
    RDFServiceImpl::GetResource(nsACString const&,nsIRDFResource * *)
[nsRDFService.cpp:1077]
    nsMsgNewsFolder::AddNewsgroup(char const*,char const*,nsIMsgFolder * *)
[nsNewsFolder.cpp:228]
    nsMsgNewsFolder::HandleNewsrcLine(char *,UINT) [nsNewsFolder.cpp:1151]
    nsMsgNewsFolder::HandleLine(char *,UINT) [nsNewsFolder.cpp:1084]
    nsMsgLineBuffer::ConvertAndSendBuffer(void) [nsMsgLineBuffer.cpp:270]
    nsMsgLineBuffer::BufferInput(char const*,int) [nsMsgLineBuffer.cpp:206]
    nsMsgNewsFolder::LoadNewsrcFileAndCreateNewsgroups(void) [nsNewsFolder.cpp:1068]

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I can't remember if this is a DUP of a bug that Timeless fixed, or not.

Comment 2

[timeless]

*** This bug has been marked as a duplicate of 212596 ***

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

lol, I'm terrible at filing DUPS these days.

shame on me.

verified dup.