198780 - Potentially unsafe non-portable cast used

Status: RESOLVED INCOMPLETE

(Core :: XPConnect, defect)

Description

[Nils Hammar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030210
Build Identifier: Mozilla/5.0 Version 1.3, attempted build under HP-UX with HP compilers/linkers

Building under HP-UX 11.00/32-bit results in the following warning, best
displayed with fixed-width font:

Warning 749: "xpcmaps.cpp", line 58 # The cast from 'const JSDHashEntryHdr *' to
 'JSDHashEntryStub *' is performed as a 'reinterpret_cast'. This operation is no
n-portable and potentially unsafe.
                    Equals(*((const nsID*)((JSDHashEntryStub*)entry)->key));
                                           ^^^^^^^^^^^^^^^^^^^
Warning 749: "xpcmaps.cpp", line 80 # The cast from 'XPCNativeSetKey *' to 'XPCN
ativeSet *' is performed as a 'reinterpret_cast'. This operation is non-portable
 and potentially unsafe.
            Set      = (XPCNativeSet*) Key;
                       ^^^^^^^^^^^^^^^


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Nils Hammar]

Warning 749: "nsStringBundle.cpp", line 571 # The cast from 'PRCListStr *' to 'b
undleCacheEntry_t *' is performed as a 'reinterpret_cast'. This operation is non
-portable and potentially unsafe.
        bundleCacheEntry_t *cacheEntry = (bundleCacheEntry_t*)current;
                                         ^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsStringBundle.cpp", line 603 # The cast from 'bundleCacheEntry_t
*' to 'PRCListStr *' is performed as a 'reinterpret_cast'. This operation is non
-portable and potentially unsafe.
        PR_REMOVE_LINK((PRCList*)cacheEntry);
        ^^^^^^^^^^^^^^
Warning 749: "nsStringBundle.cpp", line 621 # The cast from 'bundleCacheEntry_t
*' to 'PRCListStr *' is performed as a 'reinterpret_cast'. This operation is non
-portable and potentially unsafe.
      PR_INSERT_LINK((PRCList *)cacheEntry, &mBundleCache);
      ^^^^^^^^^^^^^^
Warning 749: "nsStringBundle.cpp", line 646 # The cast from 'PRCListStr *' to 'b
undleCacheEntry_t *' is performed as a 'reinterpret_cast'. This operation is non
-portable and potentially unsafe.
        cacheEntry = (bundleCacheEntry_t*)PR_LIST_TAIL(&mBundleCache);
                     ^^^^^^^^^^^^^^^^^^^^^
Warning 749: "nsStringBundle.cpp", line 658 # The cast from 'bundleCacheEntry_t
*' to 'PRCListStr *' is performed as a 'reinterpret_cast'. This operation is non
-portable and potentially unsafe.
        PR_REMOVE_LINK((PRCList*)cacheEntry);
        ^^^^^^^^^^^^^^

Comment 2

[hacker formerly known as [e-mail]]

-> xpconnect

Comment 3

[Phil Schwartau]

Formally confirming for consideration -

Comment 4

[Andrew McCreight [:mccr8]]

Ancient HPUX compiler warning bug.