Should be able to set Default Character Coding in Preferences dialog

RESOLVED FIXED

Status

defect
RESOLVED FIXED
16 years ago
15 years ago

People

(Reporter: kazhik, Assigned: rginda)

Tracking

Dependency tree / graph
Bug Flags:
blocking1.4.1 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
Preferences dialog for ChatZilla should have "Default Character Coding"
item, like Navigator and Mail.
(Reporter)

Comment 1

16 years ago
Posted patch patch v1 (obsolete) — Splinter Review
(Reporter)

Comment 2

16 years ago
Comment on attachment 118180 [details] [diff] [review]
patch v1

If you launch Mozilla with "-chat" and open the preferences dialog, the
menulist can't load any item. Otherwise this patch works fine.
Attachment #118180 - Flags: review?(rginda)

Comment 3

16 years ago
Koike Kazuhiko, how about fixing the patch so that this might land in 1.4/final?

Prog.
(Assignee)

Comment 4

16 years ago
Comment on attachment 118180 [details] [diff] [review]
patch v1

included in next xpi
Attachment #118180 - Flags: review?(rginda) → review+
(Assignee)

Comment 5

16 years ago
marking fixed, 0.8.34 checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

16 years ago
Posted patch patch v2Splinter Review
menulist is always empty now.
Attachment #118180 - Attachment is obsolete: true
(Reporter)

Updated

16 years ago
Attachment #126860 - Flags: review?(rginda)
(Reporter)

Comment 7

16 years ago
Reopening bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*** Bug 212545 has been marked as a duplicate of this bug. ***
kazhik: unofficial r+ on your patch.  It was effectively the same solution I
proposed for bug 212545.  (I'm not a reviewer on anything, but this one's so
obvious.)
Flags: blocking1.4.x?

Updated

16 years ago
Blocks: 212747
(Assignee)

Comment 10

16 years ago
added to 0.9.7
Depends on: 210744
(Assignee)

Updated

16 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Comment 11

16 years ago
The chatzilla 0.9.x branch has landed on the trunk and should be available in
tomorrow's nightly build.  If you believe this bug has not actually been fixed,
please repoen it.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED
Since this affects L10N, we can't take it for 1.4.
Flags: blocking1.4.1? → blocking1.4.1-

Comment 13

16 years ago
Comment on attachment 126860 [details] [diff] [review]
patch v2

Removing obsolete review request.
Attachment #126860 - Flags: review?(rginda)
Blocks: 229564
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.