198867 - Some of nsDocument::mPrincipal objects are leaked

Status: RESOLVED EXPIRED

(Core :: DOM: Core & HTML, defect)

Description

[Leonid Romanov]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; Debian/1.3.3.20030317-1) Gecko/20030305 Galeon/1.3.3
Build Identifier: 

This is for Mozilla 1.0.2. I haven't checked 1.3 or trunk yet, but I'm going to
do it. Attached pages load each other via JavaScript. It seems that
nsStandardURL objects with URLs of pages aren't freed, even if you quit Mozilla.

Reproducible: Always

Steps to Reproduce:
1. Add some counting facility to nsStandardURL constructor/destructor
2. Load urltest1.html
-- Or ---
1. Put urltest1.html and urltest2.html into directory with the longest path
possible, like 2K of characters.
2. Load urltest1.html
Actual Results:  
Counter goes up and never stops.
-- Or ---
Mozilla consumes more and more memory until it crashes.

Expected Results:  
Counter stops going up on some value.
-- Or ---
Mozilla frees used memory eventually.

Comment 1

[Leonid Romanov]

Attachment: First test page (urltest1.html)

Comment 2

[Leonid Romanov]

Attachment: Second test page (urltest2.html)

Comment 3

[Leonid Romanov]

I looked at nsStandardURL object's refcounter. After object has been removed
from session history, refcounter value was 1. So, I think there is one
unbalanced AddRef somewhere.

Comment 4

[benc]

-> whitebox qa

Comment 5

[Leonid Romanov]

It is not network, but content. And not nsStandardURL, but
nsDocument::mPrincipal. nsDocument::mPrincipal is raw pointer in 1.0.2, not
nsCOMPtr as in Mozilla 1.3. So, it is released manually by NS_IF_RELEASE in
nsDocument destructor. The problem is that release happens before calling
mNodeInfoManager->DropDocumentReference(). But DropDocumentReference in turn
calls nsDocuments::GetPrincipal where mPrincipal is getting initialized and
AddRef'ed again. Hence the leak.
Changing bug's title and component.

Comment 6

[benc]

please set the default owners when you hop components.

Comment 7

[Leonid Romanov]

It was fixed on trunk. See 
http://bugzilla.mozilla.org/show_bug.cgi?id=170201

Comment 8

[Johnny Stenback (:jst)]

Fixed on the trunk, marking FIXED.

Comment 9

[Leonid Romanov]

But what about the branch? It must be fixed there too. And I'm going to provide
patch for 1.0 branch. Or I don't understand bug's life cycle and "fixed" means
something else?

Comment 10

[Johnny Stenback (:jst)]

In general, the focus has moved off the 1.0 branch, but if you still has an
interest in fixing this on the branch, then feel free to open up this bug and
provide a patch.

Comment 11

[Leonid Romanov]

Reopening: I've got a patch.

Comment 12

[Leonid Romanov]

Attachment: patch converting nsDocument::mPrincipal into an nsCOMPtr

This is a patch from bug 17201, backported to 1.0 branch.

Comment 13

[Leonid Romanov]

bug 170201, sorry.

Comment 14

[Johnny Stenback (:jst)]

Comment on attachment 119085 [details] [diff] [review]
patch converting nsDocument::mPrincipal into an nsCOMPtr

sr=jst

Comment 15

[Boris Zbarsky [:bzbarsky]]

Asa, Brendan, are we still maintaining the 1.0 branch?  If so, should we land
this there?

Comment 16

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 17

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.