198956 - nsRange::GetNodeLength declares len as unsigned and uses it as signed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[timeless]

653 PRInt32 nsRange::GetNodeLength(nsIDOMNode *aNode)
 654 {
 659   PRUint32 len = -1;
 677   return len;
 678 }

This triggers warnings and is silly.

Comment 1

[Alex Vincent [:WeirdAl]]

timeless:  fixed by jst?
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/content/base/src&command=DIFF_FRAMESET&file=nsRange.cpp&rev2=1.170&rev1=1.169

Comment 2

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

This was evidently fixed long ago.  Today's nsRange::GetNodeLength returns a PRUint32.