198983 - Crash on Print in print dialog [@ SyncFrameViewGeometryDependentProperties]

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Tracy Walker [:tracy]]

seen on Mac commercial and mozilla build 2003-03-24-03-trunk

-browse a web page (tested with yahoo.com)
-click Print
-click Print in print dialog
Crash 

mac talkback servers are still not showing recent crashes. I will attache a mac
crash log.

Comment 1

[Tracy Walker [:tracy]]

Attachment: Mac Print crash log

Comment 2

[Tracy Walker [:tracy]]

Please ignore everything above the date/time stamp in the attachement. That was
inadvertently picked up in the cut and paste to TextEdit.

Comment 3

[Cathleen]

still trying to locate some layout folks to take a look....

Comment 4

[Kevin McCluskey (gone)]

peterl is taking a look.  I am also searching for possible checkins which may
have caused this.

Comment 5

[Peter Lubczynski]

-->peterl

Comment 6

[Peter Lubczynski]

looks to be crashing in a method that roc checked in code for bug 113232....I'm
updating my mac build to see if I can step through it.

Comment 7

[Kevin McCluskey (gone)]

This is the suspect change:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=&subdir=mozilla/layout/html/base/src&command=DIFF_FRAMESET&root=&file=nsContainerFrame.cpp&rev1=1.163&rev2=1.164

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

My patch is going to be backed out soon. But I'd appreciate it if you can
localize the Mac crasher so that I can fix it. Thanks.

Comment 9

[(not reading, please use [e-mail] instead)]

roc wasn't backed out,  I checked in a patch (from him) to fix bug #198946

can you update and rebuild layout, and see if you still crash?

Comment 10

[Peter Lubczynski]

updated, still crashing...trying to debug

Comment 11

[Cathleen]

Attachment: crash stack trace

this is the crash i'm seeing...  anyone else seeing this?

Comment 12

[Tracy Walker [:tracy]]

printing works with mac commercial build 2003-03-24-12-trunk.

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this still Mac only?

When I get home I'll try running valgrind and printing to see if there are any
errors creeping in on Linux.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Wait, there are two crashes in that stack. The first crash appears to be an
infinite event dispatching loop where a size change event is being dispatched,
causing the document to reflow, which resizes the root view, which dispatches a
size event, etc...

The other crash is when no background style context is found for the canvas.
Hmm.
570    // We need to set window translucency for top-level windows
571       // which have transparent backgrounds
572       if (bg->mBackgroundFlags & NS_STYLE_BG_COLOR_TRANSPARENT) {

should be
      if (hasBG && (bg->mBackgroundFlags & NS_STYLE_BG_COLOR_TRANSPARENT)) {

Hmm, that might have been causing the underlying problem in bug 198946 too.

Comment 15

[Tracy Walker [:tracy]]

sorry this is still crashing when printing www.yahoo.com.  I had tried a
different page on my earlier comment.

this is not fixed on the 2003-03-24-12-trunk mac build


yes, this is mac only

Comment 16

[Peter Lubczynski]

Yes, I just found the other crash. Adding a null check for bg stops the printing
crash for me. May I check in:

if (hasBG && (bg->mBackgroundFlags & NS_STYLE_BG_COLOR_TRANSPARENT)) {

Comment 17

[Peter Lubczynski]

cathleen says the orriginal fix to bug 113232 is getting backed out

Comment 18

[Cathleen]

making the local backout now.  make sure builds works then will get checked in.

Comment 19

[Cathleen]

my build works with backout of bug 113232.
checking backout into tree now.

Comment 20

[Tracy Walker [:tracy]]

verified; recent builds have not crashed in print dialog