1990520 - Use a specialized error when avoiding speculative connections

Status: RESOLVED FIXED

(Core :: Networking: Proxy, enhancement)

Description

[Pier Angelo Vendrame]

Speculative connections in some cases won't be performed to avoid DNS lookups: https://searchfox.org/firefox-main/rev/6cd61ea1ff39887da8f4dc1080a96c01f0c70ef8/netwerk/base/nsIOService.cpp#2214-2222.
However, that error might be reported in the console when the speculative connect is started by tab hovering: https://searchfox.org/firefox-main/rev/6cd61ea1ff39887da8f4dc1080a96c01f0c70ef8/browser/components/sessionstore/SessionStore.sys.mjs#5935-5942
Downstream in Tor Browser we might catch it quite more often (as we use a proxy filter to change SOCKS authentication on the fly and use the tor's daemon SOCKS auth isolation), so we'd like to silence it.
We thought about replacing the generic NS_ERROR_FAILURE with a new NS_ERROR_SPECULATIVE_CONNECT_DISABLED error code.

Comment 1

[Pier Angelo Vendrame]

As per the Matrix thread, that console.error could be removed instead.

Comment 2

[Pier Angelo Vendrame]

Attachment: Bug 1990520 - Remove a console.error that could be too noisy in certain configurations. r?#sessionstore-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12c6b8759c38
https://hg.mozilla.org/integration/autoland/rev/e407c3dcd137
Remove a console.error that could be too noisy in certain configurations. r=sessionstore-reviewers,sthompson

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e407c3dcd137