199068 - tab completion not working

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Felix Miata]

2003032416 Linux & 2003032412 OS/2 trunks tested (worked in previous builds:
20030322 Linux 2003032313 OS/2)

To reproduce:
1-open Chatzilla
2-join a channel
3-type first letters of a nick seen in chat window into command window
4-hit <tab>

Actual result:
1-nothing

Expected result:
1-nick is finished and a colon appended in command window

Comment 1

[[e-mail]]

/me blames bryner - see also bug 198976

Comment 2

[James Ross]

Confirmed on Windows 2000, build 2003032508, w/ ChatZilla 0.8.24.

Also, Ctrl+PageUp/PageDn, Ctrl+Tab, Ctrl+Shift+Tab also don't work.

Looks like something major, probably not-ChatZilla related. :)

Comment 3

[Michael Hendy (Hendikins)]

*** Bug 199373 has been marked as a duplicate of this bug. ***

Comment 4

[James Ross]

According to bryner, although it looks like bug 54035 broke tab-completion, the
patch to 'correct' it isn't going to help tab-completion (though, with luck, it
should fix the Ctrl-commands I found were also broken).

Comment 5

[Samuel Sieb]

Attachment: fix

not sure why it wasn't done this way in the first place...

Comment 6

[[e-mail]]

Could I point out that history isn't working quite as expected - you probably
need to cancel the event because the cursor motion effect (on windows at least
up/down maps to left/right on single-line textboxes) occurs after the history.

Comment 7

[Samuel Sieb]

Attachment: fix v2

This patch also covers Neil's comment.

Comment 8

[Robert Ginda]

Comment on attachment 119588 [details] [diff] [review]
fix v2

r=rginda

Comment 9

[Samuel Sieb]

checked in

Comment 10

[Samuel Sieb]

reopening because it broke ctrl-tab

Comment 11

[Koike Kazuhiko]

Attachment: patch(Ctrl+Tab, Ctrl+Shift+Tab)

Comment 12

[Robert Ginda]

Comment on attachment 125686 [details] [diff] [review]
patch(Ctrl+Tab, Ctrl+Shift+Tab)

included in next xpi

Comment 13

[Koike Kazuhiko]

My patch was checked in. Thank you.