199135 - [modern skin] junk mail column header icon in thread pane 2px too high (makes headers resize)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312

When the junk status column in the thread pane is being displayed, the headers
are  2 pixels higher (than when not) due to the junk mail icon that would not
fit otherwise.
This causes an ugly "jumping" effect when you toggle display of that column and
also uses some screen space it does not need.

Reproducible: Always

Steps to Reproduce:
1. Open Mozilla mail using modern theme
2. Toggle display of junk status column
Actual Results:  
The column header line resizes.

Expected Results:  
It should stay as it is.

Comment 1

[Andreas Kunz]

Attachment: Resized message-junk-other.gif image

I removed the empty top and bottom pixel lines so the icon fits in the header
without resizing it. Transparency was preserved and tested.

What I forgot to mention initially is:
- I filed this bug in Mailnews (as opposed to themes:modern) because all work
on this image has been done by mailnews people. 
- This is a kind of spin-off of bug 181452.
- There's some weirdness going on with that icon anyway: my Mozilla 1.3 in
classic theme still shows the icon that is now only in modern theme - and only
the old, misaligned version of it. I know this is a different problem, I just
wanted to mention it in case somebody does not see the problem as I do.

Comment 2

[Andreas Kunz]

Comment on attachment 118420 [details]
Resized message-junk-other.gif image

Requesting r= from sspitzer.
Not sure if it needs sr= and btw. I cannot check it in myself...

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.

I recently modified the image (to center it) but I made it too high.

thanks to [e-mail] for fixing my mistake.

Comment 4

[(not reading, please use [e-mail] instead)]

fixed.

Comment 5

[Andreas Kunz]

Verifying fixed (I think as reporter I may do so).

According to checkin comment at 03/25/2003 12:08 this has r/sr=sspitzer.
Removing request flag to remove it from his long list. 

Comment 6

[snebeling]

In 1.4rc1 (Modern theme), the table header with the junk status icon
is still 1px taller than without the icon and toggling the junk column
resizes the header vertically, so this bug is not really fixed yet.

Comment 7

[Andreas Kunz]

snebeling: well, in 1.6 I see no such error anymore. Can you try this with a
current build and maybe a new profile? I have seen strange stuff that made me
think mailnews icons sometimes are sort of cached and their updated versions not
shown for quite some time...