Closed
Bug 199169
Opened 22 years ago
Closed 22 years ago
leak of colormap from gif_write
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: tor)
Details
(Keywords: memory-leak, Whiteboard: [tind-mlk])
Attachments
(1 file)
|
666 bytes,
patch
|
paper
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
Running the bloat URLs, I see three colormaps leaked from gif_write (GIF2.cpp,
line 948). It looks like there are at least certain types of GIFs that cause
colormaps to leak.
This leak is mentioned in bug 105370 comment 12 (with better steps to reproduce
than mine).
Steps to reproduce:
1. In a trace-malloc build, run
./mozilla -f bloaturls.txt --trace-malloc=malloc.log --shutdown-leaks=sdleak.log
2. Look at sdleak.log -- it shows three leaks from gif_write.
|
Reporter | |
Updated•22 years ago
|
Whiteboard: [tind-mlk]
|
||
Comment 2•22 years ago
|
||
Comment on attachment 119659 [details] [diff] [review]
always try to free local colormap, even if the gif has switched to global
Unsolicited sr=brendan@mozilla.org.
/be
Attachment #119659 -
Flags: superreview+
Attachment #119659 -
Flags: review?(paper)
|
|
||
Updated•22 years ago
|
Attachment #119659 -
Flags: review?(paper) → review+
And really marking fixed this time...
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•