leak of colormap from gif_write

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: dbaron, Assigned: tor)

Tracking

({memory-leak})

Trunk
x86
Linux
memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tind-mlk])

Attachments

(1 attachment)

Running the bloat URLs, I see three colormaps leaked from gif_write (GIF2.cpp,
line 948).  It looks like there are at least certain types of GIFs that cause
colormaps to leak.

This leak is mentioned in bug 105370 comment 12 (with better steps to reproduce
than mine).

Steps to reproduce:
 1. In a trace-malloc build, run
./mozilla -f bloaturls.txt --trace-malloc=malloc.log --shutdown-leaks=sdleak.log
 2. Look at sdleak.log -- it shows three leaks from gif_write.
(Assignee)

Comment 1

16 years ago
Created attachment 119659 [details] [diff] [review]
always try to free local colormap, even if the gif has switched to global
Comment on attachment 119659 [details] [diff] [review]
always try to free local colormap, even if the gif has switched to global

Unsolicited sr=brendan@mozilla.org.

/be
Attachment #119659 - Flags: superreview+
(Assignee)

Updated

16 years ago
Attachment #119659 - Flags: review?(paper)

Updated

16 years ago
Attachment #119659 - Flags: review?(paper) → review+
(Assignee)

Comment 3

16 years ago
Taking...
Assignee: jdunn → tor
(Assignee)

Comment 4

16 years ago
Checked in.
(Assignee)

Comment 5

16 years ago
And really marking fixed this time...
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.