1991998 - Add telemetry to undo buttons in snackbars

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[:Gela]

We are considering removing 3 snackbars that have an undo button, but since we are not collecting telemetry, we are unclear to what extent the users utilize the undo functionality. Rather than removing them, we want to collect telemetry about the usage and if it's less than 1% DAU then we can confidently remove them.

Some notes and specifics from @Andy:

• We want to have one probe for each variation, so for example something like delete_history_snackbar_shown with an extra key undo_clicked.
• Once we have one month of data for the usage, we will make the call on whether or not this will stay.
• Lets send it directly to release, no need to bake this in nightly.

List of snackbars to collect telemetry on:

1. "Items deleted: #" and "Deleted %" snackbars - link
2. Deleted [bookmark] snackbar - link
3. Deleted [Tab name] and History Deleted snackbars - link

Comment 1

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for removing downloads [part 1]

Comment 2

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for removing a bookmark [part 2]

Comment 3

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for deleting history item(s) [part 3]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12e5f7e34f46
https://hg.mozilla.org/integration/autoland/rev/1e3a2948cae0
Add telemetry to snackbar and undo button for deleting history item(s) [part 3] r=android-reviewers,boek

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/1e3a2948cae0

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Andy Furlan has requested these bypass the Nightly bake in period so we can start collecting telemetry about the usage in Release as soon as possible.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Collects telemetry
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 7

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for deleting history item(s) [part 3]

Original Revision: https://phabricator.services.mozilla.com/D267124

Comment 8

[Dianna Smith [:diannaS]]

:gela can you elaborate on the patches?
Is only part 3 trying to get uplifted? if so can we move part 1 and 2 into another bug. It is a little confusing to track this way.

Also b9 already built, it is absolutely necessary to get these in before RC builds?

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Andy Furlan has requested these bypass the Nightly bake in period so we can start collecting telemetry about the usage in Release as soon as possible.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Collects telemetry
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 10

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for removing downloads [part 1]

Original Revision: https://phabricator.services.mozilla.com/D267081

Comment 11

[:Gela]

(In reply to Dianna Smith [:diannaS] from comment #8)

:gela can you elaborate on the patches?
Is only part 3 trying to get uplifted? if so can we move part 1 and 2 into another bug. It is a little confusing to track this way.

Also b9 already built, it is absolutely necessary to get these in before RC builds?

Sorry about the confusion, all parts 1, 2 and 3 should be uplifted. I'm not in a massive rush to get them in ASAP if the candidate's already been cut, we just want to bypass the Nightly bake in period.

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Andy Furlan has requested these bypass the Nightly bake in period so we can start collecting telemetry about the usage in Release as soon as possible.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Collects telemetry
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 13

[:Gela]

Attachment: Bug 1991998 - Add telemetry to snackbar and undo button for removing a bookmark [part 2]

Original Revision: https://phabricator.services.mozilla.com/D267098

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b45546efa994
https://hg.mozilla.org/integration/autoland/rev/432ad0ec2f9c
Add telemetry to snackbar and undo button for removing downloads [part 1] r=android-reviewers,boek

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df2fae2a76c1
https://hg.mozilla.org/integration/autoland/rev/c6a686c9659c
Add telemetry to snackbar and undo button for removing a bookmark [part 2] r=android-reviewers,skhan

Comment 16

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/432ad0ec2f9c
https://hg.mozilla.org/mozilla-central/rev/c6a686c9659c

Comment 17

[Dianna Smith [:diannaS]]

Thank. you for clarifying. Im okay with cutting the nightly bake time but this would be cutting off the beta bake time as well. I guess my question is can it ride the trains to 145? We have not cut the RC yet but the last beta was on friday

Comment 18

[:Gela]

(In reply to Dianna Smith [:diannaS] from comment #17)

Thank. you for clarifying. Im okay with cutting the nightly bake time but this would be cutting off the beta bake time as well. I guess my question is can it ride the trains to 145? We have not cut the RC yet but the last beta was on friday

No problem. We want to cut the Nightly and Beta bake time and go directly to Release. This is because this change is only collecting usage data about some snackabrs with an undo button, so we can determine if we want to remove them soon. Looks like 145 release day is set to Nov 11 which is too late. Can these 3 go into the soonest release?

Comment 19

[Dianna Smith [:diannaS]]

yes, the can ride in the next 144 mobile dot release which is October 21. can also go sooner if the opportunity arises (unplanned dot release, RC respin etc)

Comment 20

[:Gela]

Thank you, I have uplift patches in already (attached to this ticket). Is there anything else needed from my end to ensure they make it to the 144 mobile dot release?

Comment 21

[Dianna Smith [:diannaS]]

nope i can switch em over to release for you, they will be in queue

Comment 22

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/239f4347e140
https://hg.mozilla.org/releases/mozilla-release/rev/97e3515df0f3
https://github.com/mozilla-firefox/firefox/commit/63279b259284
https://hg.mozilla.org/releases/mozilla-release/rev/06df2c22c279
https://github.com/mozilla-firefox/firefox/commit/c066130f2282
https://hg.mozilla.org/releases/mozilla-release/rev/68a16ad3db6a