Closed
Bug 199201
Opened 21 years ago
Closed 21 years ago
sound settings blocks stalked messages if WAV sound file is set
Categories
(Other Applications :: ChatZilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bioram, Assigned: rginda)
References
Details
Attachments
(1 file)
862 bytes,
patch
|
rginda
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210 Set any WAV as a notification sound for private message tab or stalked message. No private messages or stalked messages are shown. Reproducible: Always Steps to Reproduce: Expected Results: WAV should be played and all messages should be shown.
Updated•21 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•21 years ago
|
||
Also ChatZilla 0.8.23 [Mozilla rv:1.4a/20030318] WinXP (although I get the private messages but in the main channel window) prefs are set to display private messages in new window Removing the custom sound and things work as expected.
Comment 2•21 years ago
|
||
*** Bug 199280 has been marked as a duplicate of this bug. ***
Comment 3•21 years ago
|
||
Might be caused by the implementation of bug 64462 (see http://bugzilla.mozilla.org/show_bug.cgi?id=64462#c154) which fits in nicely with the timeframe of somwhere between mozilla 1.1 and mozilla 1.2beta. Also of interest is bug 199201, which might cover the same problem.
Comment 4•21 years ago
|
||
The cause is nsSound::Play() doesn't work. See bug 179138. This patch handles the exception.
Updated•21 years ago
|
Attachment #119505 -
Flags: review?(rginda)
Comment 5•21 years ago
|
||
I have just tested patch v1 and it works fine for me. I.e.: on /testdisplay I do see all lines of output now, regardless of the stalk sound setting (beep or wave sound file). But I still don't hear the wav sound file being played. As just discussed with Koike this bug here seems to be about the exception handling. Perhaps the playing problem might be fixed with bug 179138.
Comment 7•21 years ago
|
||
I don't think this is Linux specific... I have the (seemingly) same problem on Windows 2000.
Assignee | ||
Comment 8•21 years ago
|
||
Comment on attachment 119505 [details] [diff] [review] patch v1 I moved the try/catch inside of playSound.
Attachment #119505 -
Flags: review?(rginda) → review+
Assignee | ||
Comment 9•21 years ago
|
||
marking fixed, 0.8.34 checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Product: Core → Other Applications
You need to log in
before you can comment on or make changes to this bug.
Description
•