199204 - Warning: nsHTMLAttributes.h: "mBits" might be used before it is set

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Philip K. Warren]

This error is showing up throughout recent builds on AIX. Its looks as if mBits
should be initialized to zero in the constructor.

"/home/tbox/builds/tinderbox/AIX_4.3_Clobber/mozilla/content/html/content/src/../../style/src/nsHTMLAttributes.h",
line 138.9: 1540-1102 (W) "mBits" might be used before it is set.

Comment 1

[Philip K. Warren]

Attachment: Patch v1

Initialize mBits to zero in the constructor.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 119367 [details] [diff] [review]
Patch v1

That patch is incorrect.  This is a *union*.

Is PRWord not the same size as a pointer on AIX?  If so, that would be an NSPR
bug.  Otherwise it's just a bogus warning.

Comment 3

[Philip K. Warren]

OK - it does seem to be a invalid warning. PRWord is the correct size on AIX.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Marking invalid per IRC discussion with pkw, who says that PRWord is the correct
size on AIX.

(The AIX compiler is treating this as a union, right?)

Comment 5

[Philip K. Warren]

Yes - it is treating this as a union, it is just giving an invalid warning.

Comment 6

[Philip K. Warren]

Comment from our compiler group on the warning message:

"This is valid.  The text of the message says might.  The C and C++ standard
also says it is invalid to access a member of a union that is not the one most
recently stored into."