1993043 - Enable layout.css.text-decoration-inset.enabled by default

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Comment 1

[Marco Mucci [:MarcoM]]

Enabling the pref for text-decoration-trim: https://bugzilla.mozilla.org/1993043 (0-points)

Comment 2

[Sebastian Zartner [:sebo]]

[Why is this notable]: New CSS property allowing authors to manipulate the length of text decorations.
[Affects Firefox for Android]: yes
[Suggested wording]: Introduced the text-decoration-trim property, which allows authors to adjust the start and end points of line decorations.
[Links (documentation, blog post, etc)]:
https://drafts.csswg.org/css-text-decor-4/#text-decoration-skip-inset-property
https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-trim (doesn't exist yet)

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1993043 - Enable layout.css.text-decoration-inset.enabled by default

This also fixes the entry in property_database.js, which has a few problems.
The first value of other_values is the same as the initial value, the value
calc(0) does not parse as a length and calc(0px) 0 will just become 0
as that is the shorted serialization of that value, and according to the
WebVTT spec text-decoration-trim should not apply to ::cue.

Comment 4

[Sebastian Zartner [:sebo]]

Note that the CSSWG hasn't decided on the name of the property yet. This will be done in https://github.com/w3c/csswg-drafts/issues/8402. See also Jonathan's comment in the other issue.

As long as this is not resolved, the pref should not be enabled by default.

Sebastian

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/77300fb4d296
https://hg.mozilla.org/integration/autoland/rev/a086e60c2482
Enable layout.css.text-decoration-inset.enabled by default r=layout-jp-market-reviewers,jfkthame

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/312ca7f12b0f
https://hg.mozilla.org/integration/autoland/rev/ac4473082467
Revert "Bug 1993043 - Enable layout.css.text-decoration-inset.enabled by default r=layout-jp-market-reviewers,jfkthame" for causing assertion failures in nsBlockFrame.cpp.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing assertion failures in nsBlockFrame.cpp.

• Revert link
• Push with failures
• Failure Log
• Failure line: Assertion failure: !HasProperty(LineIteratorProperty()) (Shouldn't have line iterators mid-reflow), at /builds/worker/checkouts/gecko/layout/generic/nsBlockFrame.cpp:X

PS. Please check also this failure.

Comment 8

[Emily McDonough [:alaskanemily]]

Addressing the failure in Bug 1997453.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aead73a2789f
https://hg.mozilla.org/integration/autoland/rev/41360b507852
Enable layout.css.text-decoration-inset.enabled by default r=layout-jp-market-reviewers,jfkthame

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/41360b507852

Comment 11

[Dianna Smith [:diannaS]]

Added to 146 release notes www.firefox.com/firefox/146.0a1/releasenotes/

Comment 12

[Dianna Smith [:diannaS]]

Relnote updated to reflect new name change "text-decoration-inset"

Comment 13

[Chris Mills [:cmills]]

See https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/text-decoration-inset.