1993071 - Account Hub Email: Add all protocol options to manual config drop down

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task, P1)

Description

[Toby Pilling [:tobyp]]

On the IMAP/POP form, we need EWS to be added. On the EWS form, we need IMAP and POP to be added.

Selecting these options should bring up the appropriate form with fields corresponding to the protocol.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1993071 - Allow switching to EWS manual config in account hub. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e25668080fb
Allow switching to EWS manual config in account hub. r=vineet,aleca

Comment 3

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

FYI browser_accountHubEmailManualIncomingForm.js is failing a bit on Windows. Example failure log.

Comment 4

[Martin Giger [:freaktechnik]]

(In reply to Geoff Lankow (:darktrojan) from comment #3)

FYI browser_accountHubEmailManualIncomingForm.js is failing a bit on Windows. Example failure log.

Thank you, at the time I was working on it try runs were unreadable so I probably missed it (or it even got shadowed). I'll try to get this fixed.

Comment 5

[Martin Giger [:freaktechnik]]

Comment on attachment 9519235 [details]
Bug 1993071 - Allow switching to EWS manual config in account hub. r=#thunderbird-front-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Make EWS account setup more versatile
• User impact if declined: Can not set up an EWS account when no config is found.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Changes manual setup logic for all email protocols in account hub.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 6

[Martin Giger [:freaktechnik]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Allows creating an EWS account without any EWS config being found. It was previously possible to edit EWS configs that were found, but this allows you to switch the manual config from IMAP/POP to EWS (or EWS to IMAP/POP).
[Suggested wording]: Add manual configuration to create EWS accounts
[Links (documentation, blog post, etc)]:

Comment 7

[Corey Bryant]

Comment on attachment 9519235 [details]
Bug 1993071 - Allow switching to EWS manual config in account hub. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Corey Bryant]

Thunderbird 145.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ecc1fae63506