199437 - xpi engine holds file handle after install/cancel

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Henrik Gemal]

A lot of times the XPI install engines seems to hold a file handle beyond the
install dialog.

This means if a script error or the user cancels the installer mozilla doesn't
seem to release the file handle to the xpi file.

This caused that it's impossible to delete or replace the xpi file without
having to shut down mozilla.

This can also been seen if you have an sysinfo util than can show file handles.

This bug must be caused by some leak or by something that doesn't release the
xpi file handle.

20030326

Comment 1

[Henrik Gemal]

to reproduce:
1) save http://gemal.dk/test/linky.xpi to local disk
2) use a sysinfo util like TaskInfo to keep an eye on the File Handles.
3) open linky.xpi from local disk. This will produce a Script Error.
4) press OK in the script error dialog
5) look at the File Handles. linky.xpi is still in the File Handles

if you use remote XPI files the file tmp-1.xpi is also keept as an active File
Handle. We should release the File Handle when the XPI install has finished!

TaskInfo:
http://www.iarsn.com/download.html

Comment 2

[Petr Kadlec]

The same is true if the XPI file is corrupt. The installation terminates with
"invalid installation package", but the file is still held open and it cannot
be deleted without Firefox shutdown.

You can reproduce it with any non-xpi file renamed to *.xpi.

Experienced in Firefox 1.0/W2k ("Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ;
rv:1.7.5) Gecko/20041108 Firefox/1.0").