Merge marshalling dlls into accessibility.dll or another dll

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({memory-footprint})

Trunk
x86
Windows XP
memory-footprint
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

16 years ago
There's an overhead associated with each extra dll.

ISimpleDOMNodeMarshal.dll and ISimpleDOMDocumentMarshal.dll could be merged into
one dll or even better, merged into accessibility.dll.

We need to make sure the install deletes the old ISimple*Marshall DLL's that it
doesn't need.

Updated

16 years ago
Keywords: footprint
(Assignee)

Comment 1

16 years ago
Created attachment 119007 [details] [diff] [review]
Combine ISimpleDOM*Marshal.dll's into AccessibleMarshal.dll

Couldn't combine them into accessible.dll because of path issues (xpcom.dll is
in a different directory).
(Assignee)

Updated

16 years ago
Attachment #119007 - Flags: superreview?(alecf)
Attachment #119007 - Flags: review?(seawood)
Comment on attachment 119007 [details] [diff] [review]
Combine ISimpleDOM*Marshal.dll's into AccessibleMarshal.dll

XPIDL_MODULE must be unique across directories as every Makefile with XPIDLSRCS
will generate a <XPIDL_MODULE>.xpt file.  XPIDL_MODULE=accessibility	is
already used by accessible/public/Makefile.in . You will need to use a new name
for that XPIDL_MODULE and add it to the respective packaging lists.
Attachment #119007 - Flags: superreview?(alecf)
Attachment #119007 - Flags: review?(seawood)
Attachment #119007 - Flags: review-
What exactly were the path issues, anyway?  How is AccessibleMarshal.dll used by
an app?
(Assignee)

Comment 4

16 years ago
Chris, when a client app (like a screen reader) tries to use ISimpleDOMNode or
ISimpleDOMDocument, it uses a marshaling .dll that we set up for cross process
communication. I used to use ISimpleDOMNodeMarshal.dll and
ISimpleDOMDocumentMarshal.dll until Alecf pointed out that I could combine them.

When I try to move them into accessibility.dll, and the client app is run, there
is an error. It said it can'tfind gkgfx.dll. That's in the bin directory, not
the components directory where accessibility.dll is. The marshalling dll has to
have all of its dependant dll's in the same directory or in the path.

Alec and I decided that we couldn't do that, so we comrpomised on combining the
two dlls into one, rather than try to put it into accessibility.dll.

(Assignee)

Comment 5

16 years ago
Created attachment 119155 [details] [diff] [review]
Uses accessibility-msaa.xpt for that accessible/public/msaa
Attachment #119007 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #119155 - Flags: review?(seawood)
Comment on attachment 119155 [details] [diff] [review]
Uses accessibility-msaa.xpt for that accessible/public/msaa

I'm confused.  Why are you removing those Makefiles from allmakefiles.sh ?  And
I don't see the actual change to XPIDL_MODULE.
Attachment #119155 - Flags: review?(seawood) → review-
(Assignee)

Comment 7

16 years ago
Created attachment 119159 [details] [diff] [review]
Oops msaa/Makefile.in was missing
Attachment #119155 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #119159 - Flags: review?(seawood)
Comment on attachment 119159 [details] [diff] [review]
Oops msaa/Makefile.in was missing

r=cls
Attachment #119159 - Flags: review?(seawood) → review+
(Assignee)

Updated

16 years ago
Attachment #119159 - Flags: superreview?(alecf)

Comment 9

16 years ago
Comment on attachment 119159 [details] [diff] [review]
Oops msaa/Makefile.in was missing

yeah, Aaron and I talked about this one. we need a seperate dll because the dll
has to be able to get to xpcom.dll. The most straight forward way of doing this
is to put it in the same dir as xpcom.dll

sr=alecf
Attachment #119159 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 10

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Comment on attachment 119159 [details] [diff] [review]
Oops msaa/Makefile.in was missing

>Index: xpinstall/packager/windows/browser.jst
>===================================================================
>RCS file: /cvsroot/mozilla/xpinstall/packager/windows/browser.jst,v
>retrieving revision 1.87
>diff -u -r1.87 browser.jst
>--- xpinstall/packager/windows/browser.jst	27 Mar 2003 02:42:40 -0000	1.87
>+++ xpinstall/packager/windows/browser.jst	2 Apr 2003 07:17:26 -0000
>@@ -383,6 +383,8 @@
>   deleteThisFile("Program",    "gkwidget.dll");
>   deleteThisFile("Program",    "jpeg3250.dll");
>   deleteThisFile("Program",    "mozreg.dll");
>+  deleteThisFile("Program",    "ISimpleDOMNode.dll");
>+  deleteThisFile("Program",    "ISimpleDOMDocument.dll");
>   deleteThisFile("Program",    "defaults/pref/config.js");
>   deleteThisFile("Program",    "defaults/pref/initpref.js");
>   deleteThisFile("Program",    "defaults/pref/psm-glue.js");

Didn't you mean to delete the old filenames:
  ISimpleDOMNodeMarshal.dll
  ISimpleDOMDocumentMarshal.dll

instead of the new ones the installer is installing?
(Assignee)

Comment 12

16 years ago
Created attachment 123163 [details] [diff] [review]
Fix file names (good catch, thanks)
Attachment #119159 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #123163 - Flags: review?(ssu)

Comment 13

16 years ago
Comment on attachment 123163 [details] [diff] [review]
Fix file names (good catch, thanks)

r=ssu
Attachment #123163 - Flags: review?(ssu) → review+
(Assignee)

Updated

16 years ago
Attachment #123163 - Flags: superreview?(alecf)

Comment 14

16 years ago
Comment on attachment 123163 [details] [diff] [review]
Fix file names (good catch, thanks)

sr=alecf
Attachment #123163 - Flags: superreview?(alecf) → superreview+
(Assignee)

Updated

16 years ago
Attachment #123163 - Flags: approval1.4?
Comment on attachment 123163 [details] [diff] [review]
Fix file names (good catch, thanks)

a=sspitzer (is there a ns tree side of this fix?)
Attachment #123163 - Flags: approval1.4? → approval1.4+
You need to log in before you can comment on or make changes to this bug.