199559 - filenames with apostrophe cannot be opened via Open Web Location

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[sairuh (rarely reading bugmail)]

if a filename contains an apostrophe, Open Web Location won't open the file.
thanks to chris for pointing this out.

reassign as needed.

tested with 2003.03.27 comm trunk builds on linux rh8.0 and mac 10.2.4..

0. make sure you have a local file whose name contains an apostrophe, eg, foo's.txt

1. hit accel+shift+L or select File - Open Web Location.

2. click Choose File to open a local file (brings up file picker), and select a
file whose name contains an apostrophe.

3. click Open, Open.

results: no file is opened. get the following in js console:

Error: missing ) after argument list
Source File: chrome://navigator/content/navigator.js
Line: 1123, Column: 96
Source Code:
openDialog('chrome://navigator/content/navigator.xul','_blank','all,dialog=no','file:///tmp/foo's.txt')

Comment 1

[sairuh (rarely reading bugmail)]

also a problem on win2k.

clarification: opening in either a new composer window or new navigator window
fail. however, opening in the current navigator window or a new tab do work.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The problem is that the delayedOpenWindow function (all three copies --
navigator.js, browser.js, editor.js) is broken.  It looks like:

1232 function delayedOpenWindow(chrome,flags,url)
1233 {
1234   setTimeout("openDialog('"+chrome+"','_blank','"+flags+"','"+url+"')", 10);
1235 }

It should probably do:

  setTimeout(openDialog, 10, "chrome", '_blank', flags, url);

right?

Comment 3

[[e-mail]]

Well... apart from the point that setTimeout only works on JS functions, we
shouldn't need all these timeout hacks.

The hack on delayedOpenWindow appears to be unnecessary - it works for me
without a timeout (the code could therefore be inlined into openLocation.js).

The hack on delayedOpenTab is currently necessary because the open location
dialog is still open when the tab is created. It would be neater for the caller
to determine the action to take, and I seem to remember filing a bug, but if so,
nothing came of it.

Comment 4

[Mike Calmus]

This seems to work correctly now using the 11/30/2004 nightly for MachO under
MacOS 10.3.7

Comment 5

[Rich Dougherty]

Seems to work correctly for me (Firefox 2/Linux). Should this bug be closed?

Comment 6

[Serge Gautherie (:sgautherie)]

Filter "spam" on "guifeatures-nobody-20080610".

Comment 7

[Arun Prasannan (polar)]

Works on SM 2.0a3pre (Slackware), and from #4 and #5 appears as if it has for a while now. Resolved Fixed.