Closed
Bug 199566
Opened 22 years ago
Closed 22 years ago
Add -inspector command-line param
Categories
(Other Applications :: DOM Inspector, enhancement)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: netdragon, Assigned: caillon)
Details
Attachments
(1 file, 1 obsolete file)
|
17.29 KB,
patch
|
timeless
:
review+
jst
:
superreview+
asa
:
approval1.4+
|
Details | Diff | Splinter Review |
"mozilla -venkman" exists. "mozilla -inspector" would be nice
"mozilla chrome://inspector/content/inspector.xul" is close as a workaround.
| Reporter | ||
Comment 1•22 years ago
|
||
dbaron mentioned that "mozilla -chrome
chrome://inspector/content/inspector.xul" gives it its own window. An even
better workaround.
| Assignee | ||
Comment 4•22 years ago
|
||
I thought we already had this (based on the fact that the documentation hewitt
wrote says we do).
I temporarily commented that out, but I have this working in my tree. I will
probably upload a patch tomorrow sometime once I make it play nicely with xpis.
Status: NEW → ASSIGNED
| Assignee | ||
Comment 5•22 years ago
|
||
Should do the trick.
| Assignee | ||
Comment 6•22 years ago
|
||
Comment on attachment 123595 [details] [diff] [review]
Command Handler
Seeking r+sr, but feel free to defer on one of them if you are so inclined.
Attachment #123595 -
Flags: superreview?(bz-bugspam)
Attachment #123595 -
Flags: review?(bz-bugspam)
Comment 7•22 years ago
|
||
I don't really know much about any of the code involved, so I'm not sure I'm a
good choice to r or sr this. In any case, I will not be able to get to it for a
while (possibly till mid-June).
| Assignee | ||
Comment 8•22 years ago
|
||
Comment on attachment 123595 [details] [diff] [review]
Command Handler
Okay, I might have misunderstood our irc conversation. I thought you knew
about this code and wanted to review it. No matter. I have a new patch
forthcoming which will also allow users to specify a URL to inspect.
Attachment #123595 -
Attachment is obsolete: true
Attachment #123595 -
Flags: superreview?(bz-bugspam)
Attachment #123595 -
Flags: review?(bz-bugspam)
| Assignee | ||
Comment 9•22 years ago
|
||
./mozilla -inspector <url>
works with this patch
Comment 10•22 years ago
|
||
Comment on attachment 123710 [details] [diff] [review]
Also allow uris to be passed in
mac script should reference Viewer not bin
(as discussed on irc)
Attachment #123710 -
Flags: review+
| Assignee | ||
Updated•22 years ago
|
Attachment #123710 -
Flags: superreview?(jst)
Comment 11•22 years ago
|
||
Comment on attachment 123710 [details] [diff] [review]
Also allow uris to be passed in
- In inspector-cmdline.js:
+ createInstance : function (outer, iid)
I see "function(...)", "function (...)", and "function (...)" in this file.
Pick one, and stick with it (I'd suggest no spaces).
sr=jst with that (and other comments in this bug) addressed.
Attachment #123710 -
Flags: superreview?(jst) → superreview+
| Assignee | ||
Comment 12•22 years ago
|
||
Comment on attachment 123710 [details] [diff] [review]
Also allow uris to be passed in
Low risk Inspector only patch: give it its own cmdline handler.
Attachment #123710 -
Flags: approval1.4?
Comment 13•22 years ago
|
||
Comment on attachment 123710 [details] [diff] [review]
Also allow uris to be passed in
a=asa (on behalf of drivers) for checkin to 1.4
Attachment #123710 -
Flags: approval1.4? → approval1.4+
| Assignee | ||
Comment 14•22 years ago
|
||
Checked in
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•21 years ago
|
Product: Core → Other Applications
Updated•18 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•