support shlibsign on OpenVMS

RESOLVED FIXED in 3.8

Status

NSS
Build
P1
normal
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Colin Blake, Assigned: Wan-Teh Chang)

Tracking

unspecified
Other
OpenVMS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

15 years ago
The shell script sign.sh in security/nss/cmd/shlibsign doesn't work on OpenVMS
(there is no LD_LIBRARY_PATH support on OpenVMS). I have created a sign.vms
shell script which does work, and my question is how should this be implemented.

Option 1. Check in sign.vms and change Makefile.in to invoke sign.vms instead of
sign.sh if OS_TARGET is OpenVMS.

Option 2. Put the contents of sign.vms into sign.sh, and instead of passing in a
IS_WINDOWS flag pass in OS_TARGET. Then inside of sign.sh we can execute the
correct sequence of commands depending upon the value of OS_TARGET.

Option 2 seems like a better solution. The current implementation of passing in
a IS_WINDOWS flag doesn't leave a lot of room for supporting other operating
systems. Option 1 is probably quicker/easier though.

Which do you want a patch for?
(Assignee)

Comment 1

15 years ago
Let's try option 2.  Thanks, Colin.
(Reporter)

Comment 2

15 years ago
Created attachment 118758 [details] [diff] [review]
Support OpenVMS in sign.sh

Make sign.sh case driven for supporting different operating systems.
(Reporter)

Updated

15 years ago
Attachment #118758 - Flags: review?(wtc)
(Reporter)

Comment 3

15 years ago
Please note that I am unable to test the above patch on any platform other than
OpenVMS.
(Reporter)

Comment 4

15 years ago
Created attachment 118783 [details] [diff] [review]
Same patch but on current code

The code I was patching just got changed by someone.
Attachment #118758 - Attachment is obsolete: true
(Reporter)

Updated

15 years ago
Attachment #118783 - Flags: review?(wtc)
(Reporter)

Updated

15 years ago
Attachment #118758 - Flags: review?(wtc)
(Assignee)

Comment 5

15 years ago
Comment on attachment 118783 [details] [diff] [review]
Same patch but on current code

Colin, at the end of the OpenVMS case, we have

>+    echo ${2}/shlibsign -v -i ${4}
>+    ${2}/shlibsign -v -i ${4}
>+    sed -e "s/\([^\.]*\)\.so/\$ deass\/job \1/" $temp > $temp2
>+    echo '$ deass/job getipnodebyname' >> $temp2
>+    echo '$ deass/job vms_null_dl_name' >> $temp2
>+    dcl @$temp2
>+    rm $temp $temp2

Can we move the shlibsign commands to the end?	That is,

>+    sed -e "s/\([^\.]*\)\.so/\$ deass\/job \1/" $temp > $temp2
>+    echo '$ deass/job getipnodebyname' >> $temp2
>+    echo '$ deass/job vms_null_dl_name' >> $temp2
>+    dcl @$temp2
>+    rm $temp $temp2
>+    echo ${2}/shlibsign -v -i ${4}
>+    ${2}/shlibsign -v -i ${4}

If so, we will be able to move the shlibsign commands
outside the case statement.
(Assignee)

Comment 6

15 years ago
Comment on attachment 118783 [details] [diff] [review]
Same patch but on current code

Bob, could you read the description of this bug
and see if you agree option 2 is the better solution?
Attachment #118783 - Flags: superreview?(relyea)
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → 3.8
(Reporter)

Comment 7

15 years ago
No can do (to comment 5). The first dcl command is setting up the environment to
run shlibsign, and the second dcl command is destroying it.
(Assignee)

Comment 8

15 years ago
Comment on attachment 118783 [details] [diff] [review]
Same patch but on current code

r=wtc.	(relyea's "second" review is optional.)

Requesting mozilla 1.4alpha approval. This patch allows
Mozilla to build on OpenVMS after the NSS 3.8 landing.
The risk of the patch is low.
Attachment #118783 - Flags: review?(wtc)
Attachment #118783 - Flags: review+
Attachment #118783 - Flags: approval1.4a?

Comment 9

15 years ago
Comment on attachment 118783 [details] [diff] [review]
Same patch but on current code

a=asa (on behalf of drivers) for checkin to 1.4a. Time is short so this needs
to land soon if it's gonna make it.
Attachment #118783 - Flags: approval1.4a? → approval1.4a+
(Assignee)

Comment 10

15 years ago
Fixed checked into the NSS TIP (NSS 3.8) and NSS_CLIENT_TAG
(mozilla 1.4alpha).
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Updated

14 years ago
Attachment #118783 - Flags: superreview?(rrelyea0264) → superreview+
You need to log in before you can comment on or make changes to this bug.