Closed
Bug 199655
Opened 23 years ago
Closed 23 years ago
parseInt used instead of Math.round in printProgress.js, sendProgress.js, and MsgComposeCommands.js
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: schapel, Assigned: jag+mozilla)
Details
(Keywords: perf)
Attachments
(1 file, 1 obsolete file)
|
2.24 KB,
patch
|
jag+mozilla
:
review+
bryner
:
superreview+
asa
:
approval1.4b+
|
Details | Diff | Splinter Review |
This line of code is repeated in the three source files printProgress.js,
sendProgress.js, and MsgComposeCommands.js:
percent = parseInt( (aCurTotalProgress*100)/aMaxTotalProgress + .5 );
This can be replaced with:
percent = Math.round( (aCurTotalProgress*100)/aMaxTotalProgress );
which is faster and easier to read.
|
Reporter | |
Comment 1•23 years ago
|
||
-> XP Apps
Assignee: asa → jaggernaut
Component: Browser-General → XP Apps
QA Contact: asa → paw
|
|
Reporter | |
Updated•23 years ago
|
Blocks: patchmaker
Attachment #120875 -
Attachment is obsolete: true
Attachment #120882 -
Flags: review?(jaggernaut)
|
Assignee | |
Updated•23 years ago
|
Attachment #120882 -
Flags: superreview?(bryner)
Attachment #120882 -
Flags: review?(jaggernaut)
Attachment #120882 -
Flags: review+
|
|
||
Updated•23 years ago
|
Attachment #120882 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Updated•23 years ago
|
Attachment #120882 -
Flags: approval1.4b?
|
||
Comment 4•23 years ago
|
||
Comment on attachment 120882 [details] [diff] [review]
A file was missing
a=asa (on behalf of drivers) for checkin to 1.4beta.
Attachment #120882 -
Flags: approval1.4b? → approval1.4b+
|
|
Assignee | |
Comment 5•23 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•23 years ago
|
No longer blocks: patchmaker
|
||
Updated•21 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•