Closed
Bug 199704
Opened 22 years ago
Closed 22 years ago
Unused function GetElementByAttribute() in nsXULDocument.cpp
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.4beta
People
(Reporter: rbs, Assigned: rbs)
Details
(Whiteboard: [HAVE FIX])
Attachments
(1 file)
|
1.45 KB,
patch
|
peterv
:
review+
jst
:
superreview+
asa
:
approval1.4a-
|
Details | Diff | Splinter Review |
Likely a fallout from bug 124412. As far as I can tell, nobody uses
GetElementByAttribute() in nsXULDocument.cpp. There is an identical copy of it
in nsDocument.cpp instead.
|
||
Comment 2•22 years ago
|
||
Comment on attachment 118801 [details] [diff] [review]
patch to remove the obsoleted code
Nice catch, rbs! sr=jst
Attachment #118801 -
Flags: superreview+
|
|
||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla1.4beta
Comment on attachment 118801 [details] [diff] [review]
patch to remove the obsoleted code
asking r/sr for no code :-)
Attachment #118801 -
Flags: superreview?(jst)
Attachment #118801 -
Flags: review?(alecf)
|
|
||
Updated•22 years ago
|
Attachment #118801 -
Flags: superreview?(jst)
|
||
Updated•22 years ago
|
Attachment #118801 -
Flags: review?(alecf) → review+
Comment on attachment 118801 [details] [diff] [review]
patch to remove the obsoleted code
Asking a=1.4a from drivers. Patch to reduce foot-print by removing some dead
code that has been obsoleted by recent checkins.
Attachment #118801 -
Flags: approval1.4a?
|
||
Comment 6•22 years ago
|
||
Comment on attachment 118801 [details] [diff] [review]
patch to remove the obsoleted code
please land this change first thing in 1.4beta. thanks.
Attachment #118801 -
Flags: approval1.4a? → approval1.4a-
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•