1998732 - Update "emulation.setGeolocationOverride" command reset behavior

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Alexandra Borovova [:Sasha]]

The reset behaviour emulation.setGeolocationOverride command was updated with https://github.com/w3c/webdriver-bidi/pull/1026. With this update, the command should only reset an override for browsing contexts in case the contexts argument is provided and only user contexts if userContexts argument is set.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1998732 - [webdriver-bidi] Update "emulation.setGeolocationOverride" command reset behavior.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1998732 - [wdspec] Add a test for "emulation.setGeolocationOverride" command to set an override to a browsing context and then to a user context.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1998732 - [webdriver-bidi] Update "emulation.setScreenOrientationOverride" command reset behavior.

Comment 4

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1998732 - [wdspec] Add a test for "emulation.setScreenOrientationOverride" command to set an override to a browsing context and then to a user context.

Comment 5

[Phabricator Automation]

Comment on attachment 9535924 [details]
Bug 1998732 - [webdriver-bidi] Update "emulation.setScreenOrientationOverride" command reset behavior.

Revision D278001 was moved to bug 1998734. Setting attachment 9535924 [details] to obsolete.

Comment 6

[Phabricator Automation]

Comment on attachment 9535925 [details]
Bug 1998732 - [wdspec] Add a test for "emulation.setScreenOrientationOverride" command to set an override to a browsing context and then to a user context.

Revision D278002 was moved to bug 1998734. Setting attachment 9535925 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7174cf83a2d3
https://hg.mozilla.org/integration/autoland/rev/4fa0a57b5dba
[webdriver-bidi] Update "emulation.setGeolocationOverride" command reset behavior. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/786d57bafac1
https://hg.mozilla.org/integration/autoland/rev/0643a28e17d6
[wdspec] Add a test for "emulation.setGeolocationOverride" command to set an override to a browsing context and then to a user context. r=jdescottes

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/57040 for changes under testing/web-platform/tests

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4fa0a57b5dba
https://hg.mozilla.org/mozilla-central/rev/0643a28e17d6

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot