1998886 - Backup option appear under about:preferences#experimental page.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Monica Chiorean]

Attachment: 2025-11-07_10h31_40.png

Found in

• version: 145.0

Affected versions

• versions: 146.0a1, 145.0

Tested platforms

• Affected platforms: Windows,
• Unaffected platforms: Ubuntu, Mac

Preconditions:

• browser.backup.enabled - true
• browser.backup.archive.enabled - true
• browser.backup.restore.enabled - true

Steps to reproduce

1. Have a clean profile.
2. Enable backup prefs.
3. Perform a backup.
4. Go to about:preferences#experimental and check the page.

Expected result

• Backup settings should not be displayed only under about:preferences#sync page.

Actual result

• Backup settings are displayed under about:preferences#experimental page.

Regression range

• Could be related to bug#1983910, but will look into it.
• Reproduces on both nightly and 145.0.

Comment 1

[Monica Chiorean]

I checked on an older build 145.0a1(20250915214414) before fix on bug1983910, and the experimental page redirects me to general page.

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1998886 - Add a method to change visibility based on prefs for about:preferences. r=#backup-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5146d651fbe3
https://hg.mozilla.org/integration/autoland/rev/448336c0315d
Add a method to change visibility based on prefs for about:preferences. r=hjones,cdupuis

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/448336c0315d

Comment 5

[Monica Chiorean]

Verified issue as fixed on Win11x64 using FF build 147.0a1(20251111094532).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hsohaney, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox146 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1998886 - Add a method to change visibility based on prefs for about:preferences.

Original Revision: https://phabricator.services.mozilla.com/D271824

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: No impact, requirment for FxBackup 145 dot release.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Changes are for fxbackup settings.
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fda722aa0a6a
https://hg.mozilla.org/releases/mozilla-beta/rev/2dd11f618bd6
Add a method to change visibility based on prefs for about:preferences. r=hjones,cdupuis

Comment 10

[Dianna Smith [:diannaS]]

Comment on attachment 9525405 [details]
Bug 1998886 - Add a method to change visibility based on prefs for about:preferences. r=#backup-reviewers

Approved for 146.0b5

Comment 11

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1998886 - Add a method to change visibility based on prefs for about:preferences.

Original Revision: https://phabricator.services.mozilla.com/D271824

Comment 12

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: FxBackup dot release. User's on windows 10 will not be able to backup their user data locally when shifting to a new device, which could lead to some churn issues.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: QA will be testing this build. The steps are provided to them already.
• Risk associated with taking this patch: low
• Explanation of risk level: FxBackup dot release
• String changes made/needed: No
• Is Android affected?: no

Comment 13

[Monica Chiorean]

Verified as fixed on Win10(old)/Win11 using 145.0.2 try build that we have for testing, not changing the tracking flags yet, until the official build is released.

Comment 14

[Monica Chiorean]

Verified as fixed on Win10(old)/Win11 using FF build 146.0b8 (20251125090806).

Comment 15

[Monica Chiorean]

Marking as verified, since it is disabled on 145.0.