this would also fix bug 173634, right?
It would fix the original summary for bug 173634 but I'm not sure what it morphed into.
Created attachment 118968 [details] [diff] [review] v1.0 (checked in) * Move XP_IS_ macros into nsCRT.h & rename them to NS_IS_ * Make local XP_IS_ macros use the nsCRT ones * Remove NOT_NULL defines
Attachment #118968 - Flags: superreview?(bryner) → superreview+
Comment on attachment 118968 [details] [diff] [review] v1.0 (checked in) yee haw! Nice job chris. So good to see these things gone.
Attachment #118968 - Flags: review?(alecf) → review+
Attachment #118968 - Attachment description: v1.0 → v1.0 (checked in)
Created attachment 119132 [details] [diff] [review] remove include/ from build When the patches from bug 171883 land, this can be checked in and everything in mozilla/include can be cvs removed.
Comment on attachment 118968 [details] [diff] [review] v1.0 (checked in) Just some notes on the patch, if anyone cares: 1. The lines at http://lxr.mozilla.org/seamonkey/source/mailnews/base/public/msgCore.h#87 Now read: 87 #if defined(XP_WIN) || defined(XP_OS2) 88 #define IS_ALPHA(VAL) NS_IS_ALPHA(VAL) 89 #else 90 #define IS_ALPHA(VAL) NS_IS_ALPHA(VAL) 91 #endif .. which seems a little redundant to me. 2. Should the define for the first NS_IS_ALPHA variant in nsCRT.h be #ifdef XP_WIN || XP_OS2, to match what was taken from msgCore.h?
1. I know. Didn't seem like it was worth redoing the patch to fix. 2. Nice catch.
mozilla/include has been removed from the build sytsem and cvs removed.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.4beta
You need to log in before you can comment on or make changes to this bug.