200027 - home and end snap inside of links when link is the first of last thing on the line

Status: RESOLVED DUPLICATE of bug 1357365

(Core :: DOM: Selection, defect)

Description

[mjudge]

open composer, drop link. click somewhere on page. hit home, type.  see how the
link is continued and you cannot get out of the link without clicking.

Comment 1

[mjudge]

Attachment: patch for layout\html\base\src

patch that stops getcontentandoffsetsfrompoint from traversing children of a
frame that is a link. ONLY if the point passed in is outside of that frame.

Comment 2

[mjudge]

marking editorbase for someone to + it

Comment 3

[mjudge]

Attachment: nicer patch for nsFrame.cpp

re did patch. previous patch was confusing with the cvs diff options.  this
basically shows the new GetContentOffsetsFromPoint method.

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 120635 [details] [diff] [review]
nicer patch for nsFrame.cpp

1)
You do
  result = GetRect(thisRect);
but you are not checking result. Should you?


2)
You are calling GetClosestViewForFrame() (existing call)
and directly after it you are you calling GetOffsetFromView().

Might you be able to get rid of the call to GetClosesViewForFrame(), 
and check the view returned from GetOffsetFromView for being not null?


3)
What about renaming "isLink" to "pointIsOutsideLink"?

Comment 5

[Kai Engert [:KaiE:]]

Attachment: (whitespace ignore version of patch to ease reviewing)

Comment 6

[mjudge]

just have to fixup possibly bitrotted code and resubmit patch for review.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, Home and End should put caret before/after the first/last link.