2001906 - Selecting multiple tabs using Shift-Click and adding a note only adds note to the tab that was clicked despite multiple tabs being selected

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Tobias (:Tobbi) Markus]

Steps to reproduce:

1. Open multiple tabs in a session.
2. Select any number of these opened tabs by holding down the Shift key, then selecting some of the tabs in sequence.
3. Right-click on one of the tabs, select "Add Note", then add a note and confirm.
4. Right-click on any of the tabs you selected.

Expected results:
Either all but the active tabs get unselected before adding a note, the "add note" function is not available when selecting multiple tabs or the note is added to all of the selected tabs.

Actual results:
The note is only added to the tab you right-clicked on (all the other context menu options refer to the group, this is the only one that doesn't).

Comment 1

[Stephen Thompson [:sthompson]]

We'll address this with the following logic:

• if all multiselected tabs have the same canonical URL, allow the "add note"/"edit note" context menu entry
• if the multiselected tabs have more than one canonical URL, disable the "add note"/"edit note" context menu entry

Comment 2

[Jeremy Swinarton]

Attachment: Bug 2001906: Improve multiselect behaviour for tab notes r?dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7f62c9b514c
https://hg.mozilla.org/integration/autoland/rev/361696d69437
Improve multiselect behaviour for tab notes r=dwalker,tabbrowser-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/361696d69437